Skip to content

IRSA-7248: Fix combined Euclid spectra (and multi-trace chart) bugs #1860

Merged
jaladh-singhal merged 2 commits intodevfrom
IRSA-7248-combine-charts-bugs
Oct 14, 2025
Merged

IRSA-7248: Fix combined Euclid spectra (and multi-trace chart) bugs #1860
jaladh-singhal merged 2 commits intodevfrom
IRSA-7248-combine-charts-bugs

Conversation

@jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Oct 11, 2025

Fixes IRSA-7248: refer to my comment on this ticket since it has evolved since it was created

  • Allow re-render of useBasicOptions components when trace changes - this was a regression issue, likely introduced in this PR
  • The chart modifications trigger addScatterChanges (to handle table source connections for other traces), which doesn't always have y defined causing chart to throw runtime error and get stuck loading

Testing

Firefly: https://fireflydev.ipac.caltech.edu/irsa-7248-combine-charts-bugs/firefly

  • Upload a spectra file with more than one traces (use the Spitzer spectra linked in ticket)
  • Open chart options (gears dialog), check you can change trace from "choose trace" listbox and it reflects changes in the listbox and trace options fields
  • Do any modification. change chart title, apply -> change trace -> apply -> no errors in console/ chart shouldn't get stuck

Euclid: https://irsa-7248-combine-charts-bugs.irsakubedev.ipac.caltech.edu/applications/euclid

Combine a few spectra rows, and open chart options for the combined spectra chart. Then do same as above or items 3, 7, 8 from @lrebull's Euclid testing list. They shouldn't make chart freeze.

NOTE: multi-trace chart still has some problems when applying chart modifications from the dialog because some of them propogate to other traces and some don't and then changing trace causes things like error bars, redshift spectral frame to disapper, etc. But we should track them in separate ticket (since they may require some redesign of dialog itself).

@jaladh-singhal jaladh-singhal added this to the 2025.5 milestone Oct 11, 2025
@jaladh-singhal jaladh-singhal self-assigned this Oct 11, 2025
@jaladh-singhal jaladh-singhal added bug Charts Anything related to charts labels Oct 11, 2025
@lrebull
Copy link
Contributor

lrebull commented Oct 13, 2025

very nice! i can't make it crash!

Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good.

@jaladh-singhal jaladh-singhal merged commit 655f5ef into dev Oct 14, 2025
@robyww robyww deleted the IRSA-7248-combine-charts-bugs branch November 19, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Charts Anything related to charts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants