IRSA-7248: Fix combined Euclid spectra (and multi-trace chart) bugs #1860
Merged
jaladh-singhal merged 2 commits intodevfrom Oct 14, 2025
Merged
IRSA-7248: Fix combined Euclid spectra (and multi-trace chart) bugs #1860jaladh-singhal merged 2 commits intodevfrom
jaladh-singhal merged 2 commits intodevfrom
Conversation
Contributor
|
very nice! i can't make it crash! |
loitly
approved these changes
Oct 13, 2025
Contributor
loitly
left a comment
There was a problem hiding this comment.
The code changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IRSA-7248: refer to my comment on this ticket since it has evolved since it was created
useBasicOptionscomponents when trace changes - this was a regression issue, likely introduced in this PRaddScatterChanges(to handle table source connections for other traces), which doesn't always haveydefined causing chart to throw runtime error and get stuck loadingTesting
Firefly: https://fireflydev.ipac.caltech.edu/irsa-7248-combine-charts-bugs/firefly
Euclid: https://irsa-7248-combine-charts-bugs.irsakubedev.ipac.caltech.edu/applications/euclid
Combine a few spectra rows, and open chart options for the combined spectra chart. Then do same as above or items 3, 7, 8 from @lrebull's Euclid testing list. They shouldn't make chart freeze.