IRSA-7344: Download Dialog Improvements and Bug fixes#1864
Conversation
|
DCE is broken for me immediately: |
|
Firefly build -> SIAv2 searches -> CADC ObsCore -> m16, IRSA -> picked four rows, asked it for all data, including 10 arcmin cutouts, got this in the README, which makes it look like the cutouts failed, but I got cutouts with my download which appear to be correct..?: |
|
cutout is not a choice in this spherex build (see there is no icon on the right above the image), so i cannot change it to test what it does. |
|
For SPHEREx:
|
|
tried SPHEREx-> TAP -> CADC ObsCore -> prepare download -> Curl script, got these errors:
|
|
I just killed the SPHEREx download script because it was in the process of downloading 20,000 files. That doesn't seem reasonable for selecting three rows from an image search. Something is really, really wrong here. |
|
SpectralImages-curl.sh |
|
Euclid seems to be working ok; it just takes a long time because the images are large. . . |
Ok yes this is the main bug. Can you help me recreate it @lrebull? What search did you do to get this download script? And did you select all rows / all data from the search results? I see the download script you attached does have ~20,000 files that it's trying to download, but some are repeated (~1800 times each!). So I'll need to inspect what's going on here. |
|
And re: DCE @lrebull. I just built it again. It should work now. https://irsa-7344-euclid-downloads-fixes.irsakubedev.ipac.caltech.edu/irsaviewer/dce |
still broken for me - tried shift-reload, AND 'new private window.' 
|
I'm trying to reconstruct exactly what I did. It looks like I searched on 183.366574968281, -35.67588279090248 (which was almost certainly stabbing randomly on the sky). I got 120 images, so it's not in a deep field where I expect a gazillion hits. then i picked three rows from the results table -- probably three of tile 2025W22_1B_0542_4, the last of the D2's and the D3/D5 matched pair, so the 4th, 5th, and 6th in the list that is returned by the search. Then I asked for a curl script. I got 40,734 rows in that script just now. |
|
Ok @lrebull @robyww it seems like most of the weird issues with the download script might be backend issues. So what I would like you to test for this PR is: In a nutshell: No need to try and run the download script. Essentially just want you to test that cutout size updates are respected in the download dialog. And that you don't see 2 download buttons anywhere (
|
|
Firefly - test works |
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
The code looks but but I noticed a couple of small UI things you should fix. I should have seen it on previous PRs, but the are easy fixed.
UI
- I don't think I saw this before. You should call ZoomUtil.js
makeFoVStrhere. It will look better, This the what you see on the toolbar. It will also be more concistent
- I is is better UI to have something selected. In this case you should always select
Primary Productif it is there.
| const hasProductBlock = !!productTypes || formInputs?.productTypes !== undefined; | ||
|
|
||
| //if product types (checkboxes) exist but no selection was made | ||
| if (hasProductBlock && (!productTypes || productTypes.trim() === '')) { |
There was a problem hiding this comment.
if (hasProductBlock && (!productTypes?.trim())
kpuriIpac
force-pushed
the
IRSA-7344-euclid-downloads-fixes
branch
from
9bc7547 to
d7f14a6
Compare
kpuriIpac
force-pushed
the
IRSA-7344-euclid-downloads-fixes
branch
from
d7f14a6 to
4d02bef
Compare
3 participants
Ticket:
Show table of all Euclid products) was displaying two download buttonsObsCorelike tables recently got better, and recognized datalink tables as obscore-ish tables and added a download button to them. Now, adding a check in theDefaultSearchActions'showDatalinkTableto ensure it doesn't already have a download button fixes this.Note: The default mode for checkboxes in our download dialogs is that all products will be unselected. If you'd like me to change it to rather make everything selected by default, let me know.
Testing:
Prepare Downloadbutton shows up. If cutouts exist, attempt to change the cutout size and ensure that you see the updated cutout size in the download dialogs when you select the cutout checkbox.Prepare Downloadworks as expected.Generate Download Buttoneverywhere, including on TAP and Euclid Catalog results.Prepare DownloadbuttonShow table of all Euclid products(or spherex) to see the products table. Ensure you only see one download (Generate Download Script) button.