Conversation
robyww
force-pushed
the
FIREFLY-1835-react19
branch
from
5d30e62 to
685097e
Compare
robyww
added
UI
robyww
force-pushed
the
FIREFLY-1835-react19
branch
from
685097e to
0c0dab5
Compare
loitly
approved these changes
Oct 17, 2025
Contributor
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
Changes look good. I spot-tested the applications, and everything seem to be working fine.
| import PropTypes from 'prop-types'; | ||
| import {Box, ChipDelete, Divider, Stack} from '@mui/joy'; | ||
| import {get, isEmpty, isUndefined} from 'lodash'; | ||
| import {wrapResizer} from '../../ui/NewResizer'; |
Contributor
There was a problem hiding this comment.
I suggest not using the word 'New' in the name, since it may lose relevance over time. Since it exports a function rather than the component itself, a name like ResizeHelper (or something similar) would be more suitable.
Contributor
Author
There was a problem hiding this comment.
I agree, I was using the name in an experiment. I meant to change it.
kpuriIpac
approved these changes
Oct 17, 2025
Contributor
kpuriIpac
left a comment
kpuriIpac
left a comment
There was a problem hiding this comment.
Tested the apps with a few basic searches and uploads. Everything looks good.
- Replace react-sizeme with newer JS API ResizeObserver - React-sizeme does not support react 19. - Remove unsupported defaultProps - propTypes are still in the code but react now ignores them. - Removed uses for forwardRef - The ref is now passed as a prop without using forwardRef - Updated some other packages, as many as easily possible. - Updated supported browser list (no driver here, just an annual task)
robyww
force-pushed
the
FIREFLY-1835-react19
branch
from
0c0dab5 to
b5e95f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1835: Upgrade to react 19
react-sizemewith newer JS APIResizeObserverreact-sizemedoes not support react 19.defaultPropspropTypesare still in the code but react now ignores them.forwardRefforwardRefTesting