Skip to content

Firefly-1886: Improve extract tool behavior for MEFs#1868

Merged
robyww merged 1 commit intodevfrom
FIREFLY-1886-extract
Oct 24, 2025
Merged

Firefly-1886: Improve extract tool behavior for MEFs#1868
robyww merged 1 commit intodevfrom
FIREFLY-1886-extract

Conversation

@robyww
Copy link
Contributor

@robyww robyww commented Oct 21, 2025

Firefly-1886: Improve extract tool behavior for MEFs

  • if Aperture is set beyond 1x1, then evaluate the HDU name for has to combine

Testing

  - if Aperture is set beyond 1x1, then evaluate the HDU name for hos to combine
@robyww robyww added this to the 2025.5 milestone Oct 21, 2025
@robyww robyww self-assigned this Oct 21, 2025
@robyww robyww added enhancement Image FITS images labels Oct 21, 2025
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. However, I have a question:
Right now, the prompt for secondary combine appears when selecting “Pin Chart/Table.”
Would it make more sense to show this prompt when “Aperture” is selected and it’s not 1x1 instead?
This would let users preview the chart before pinning it and eliminate the need to select “Pin Chart/Table” twice.

@robyww
Copy link
Contributor Author

robyww commented Oct 22, 2025

The reason is the check box would be is meaningless until you pin. The options (size and combine type) are using immediately.

Also for line and point extract we already show a more complex dialog because there are many more extraction options. So it is part of the flow.

@robyww robyww merged commit 5c7a41d into dev Oct 24, 2025
@robyww robyww deleted the FIREFLY-1886-extract branch November 19, 2025 17:47
@lrebull
Copy link
Contributor

lrebull commented Dec 4, 2025

FYI, i am not seeing any of these changes on irsaviewer dev or test when using spherex data. should i be seeing these changes? i thought i had seen them at one point, but i am not currently seeing them on dev or test irsa viewer. do they only appear in spherex?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants