FIREFLY-1884: Fix Plot Parameter dialog reflecting incorrect state of plotted column#1869
Merged
jaladh-singhal merged 1 commit intodevfrom Oct 24, 2025
Merged
Conversation
|
I uploaded the file in the https://fireflydev.ipac.caltech.edu/firefly-1884-charts-dialog-state-bug/firefly and it now works as expected and desired! |
vandesai1
approved these changes
Oct 24, 2025
robyww
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-1884
Bug was happening because when alias is provided, it couldn't find that string in options list. Updated it to use the corresponding option value instead of original string.
Testing
https://fireflydev.ipac.caltech.edu/firefly-1884-charts-dialog-state-bug/firefly
Check that the issue described in ticket should no longer be reproducible.