Skip to content

IRSA-7404: Fix for grid options not showing in MultiProductViewer#1871

Merged
kpuriIpac merged 1 commit intodevfrom
IRSA-7404-euclid-grid-not-showing
Nov 3, 2025
Merged

IRSA-7404: Fix for grid options not showing in MultiProductViewer#1871
kpuriIpac merged 1 commit intodevfrom
IRSA-7404-euclid-grid-not-showing

Conversation

@kpuriIpac
Copy link
Contributor

@kpuriIpac kpuriIpac commented Oct 27, 2025

Ticket: https://jira.ipac.caltech.edu/browse/IRSA-7404

  • This affects Euclid right now, but is a generic bug
  • In some cases, the grid doesn't show up for images even when canGrid was set to true via dataProductsFactoryOptions
    • For Euclid specifically, you can see in ResultsViewer that we set canGrid: true when calling MultiProductViewerContainer
      • and this is respected in Image, Inspect Objects and Search by ID Objects searches
      • it only doesn't work for Search by ID Image search, so I tracked it down as follows:
        • following the watcher in MetaDataMultiProductViewer, we get to makeDataProductsConverter in DataProductsFactory
          • in here is where I noticed the retObj has canGrid: false for the Search by ID image search case
          • following the converter's factory function, in the case of Image search (mer-tiles, so both Image search and Search by ID Image search) , it happens to be makeObsCoreConverter
            • this is where canGrid is set to false, when ensureOnlyImageInTable is called
              • but since we set limitViewerDisplay to IMAGE_ONLY, it's my understanding that the fix should take care of this bug
  • The 2nd bug reported in the ticket:
    • if you do a Search by ID Image search (try 102018211), go to the spectra tab in the results
    • a lot of the rows show the Table | Chart option instead of the standard No data available for this row as is expected for an Image search
    • Upon inspecting the table, it appears that a lot of the entries in the dataproduct_type column are, in fact, spectrum
      • so could this be a backend bug?

Testing:

@kpuriIpac kpuriIpac added this to the 2025.5 milestone Oct 27, 2025
@kpuriIpac kpuriIpac requested a review from robyww October 27, 2025 23:59
@kpuriIpac kpuriIpac self-assigned this Oct 27, 2025
@kpuriIpac kpuriIpac added the bug label Oct 28, 2025
@kpuriIpac kpuriIpac force-pushed the IRSA-7404-euclid-grid-not-showing branch from 5cfddfd to 0bf1192 Compare November 3, 2025 20:34
@kpuriIpac kpuriIpac merged commit d27dcdc into dev Nov 3, 2025
@kpuriIpac kpuriIpac deleted the IRSA-7404-euclid-grid-not-showing branch November 3, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants