Firefly-1889: update table row viewer with improved masking#1873
Conversation
10abbff to
5cf5535
Compare
|
I looked at the old PR and this PR. It's of course a complex component, code would probably be better reviewed by @jaladh-singhal when he's back (not blocking for this PR, I just mean in a future iteration of work with this code). I think the masking is working better, but I did notice a few small issues:
This looks. fine as
I am not suggesting this necessarily needs fixing, but just wanted to highlight it (the fact that only the image on the far right says Looks good other than that! |
kpuriIpac
left a comment
There was a problem hiding this comment.
Looks good! Spent time trying to study code in the old PR and this one. Might need a deeper review eventually as well, but looks good to me.
62ede9e to
6feb1ea
Compare


Firefly-1889: update table row viewer with improved masking
PlotViewlike look during workingTesting
PlotViewlike masking when sliding.