FIREFLY-1880: Enable uploads and pinning spectra in spherex#1875
FIREFLY-1880: Enable uploads and pinning spectra in spherex#1875
Conversation
| wpRequest.setRotateNorth(true); | ||
| dispatchPlotImage({ | ||
| plotId, wpRequest, | ||
| viewerId, |
There was a problem hiding this comment.
I guess it is a good think you spent some time with my ImageTableRowViewer PR! good catch!
There was a problem hiding this comment.
yeah this is what was causing the spectrum cutouts showing up in the Pinned Images tab as well! spent longer than I thought I would trying to catch this hah.
|
|
||
|
|
||
| function BadgeLabel({labelStr}) { | ||
| export function BadgeLabel({labelStr}) { |
There was a problem hiding this comment.
since you are now exporting this component why don't you change the name to something more specific. Such as ImagePinnedBadgeLabel
There was a problem hiding this comment.
You're right. I had initially changed it to ImageBadgeLabel and then changed it back to BadgeLabel but then just imported it as ImageBadgeLabel (because there's already a BadgeLabel for charts as well). I think I'll change the Chart one's name to ChartBadgeLabel as well.
kpuriIpac
force-pushed
the
FIREFLY-1880-enable-spectra-spherex
branch
from
c419890 to
4caa984
Compare
2 participants
Tickets: FIREFLY-1880 , FIREFLY-1878
IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/447
dispatchPlotImageis the crucial fix here to ensure the spectrum cutouts don't show up in thePinned Imagestab as well when you upload new images.DEFAULT_FITS_VIEWER_ID), and if we don't pass in the customviewerIdtodispatchPlotImageforImageTableRowViewer, it'll also default to the default viewerId.