FIREFLY-1833: Fix Python client functions don't switch to Results tab if any other tab is selected#1906
Merged
jaladh-singhal merged 1 commit intodevfrom Feb 5, 2026
Merged
Conversation
jaladh-singhal
added
bug
UI
robyww
approved these changes
Feb 4, 2026
Contributor
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
Looks good.
I am most concerned about checking the menu state before calling the dispatch. I think if you do that it is ready to go.
Always glad to see more documentation.
loitly
approved these changes
Feb 4, 2026
Contributor
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
Tested and confirmed it works as described. The code looks good.
Documentation updates
jaladh-singhal
force-pushed
the
FIREFLY-1833-tab-switch
branch
from
3ceeb10 to
3cb7bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-1833
This was a two part problem:
layoutInfoin the store esp when results are available. Added an effect inMenuto listen tolayoutInfo.dropdownand update the selected tab when results view.dropdownHandlerdoesn't updatelayoutInfo.dropdownwith recent payload correctly becauseview: undefinedused for Results view gets ignored when merging objects and the new state has old view.Testing
Point to this firefly server: https://fireflydev.ipac.caltech.edu/firefly-1833-tab-switch/firefly
Follow the instructions in the ticket. Also try other
fc.show_*methods (can use reference guide notebook for testing). The menu tab should switch to "Results" if not already there as the method gets executed.