FIREFLY-1935: Alert Viewer by kpuriIpac · Pull Request #1917 · Caltech-IPAC/firefly

kpuriIpac · 2026-03-03T01:08:46Z

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1935

Implement Alert Viewer template
Improved server side logic by adding a search processor based on feedback
The processor retrieves & downloads the file, and then uses the existing AlertAnalyzer, then returns the parts (2 tables and 3 images) back to client as JSON
- each JSON entry also includes the file location, in case we support multiple (more than one) files later
This in turn simplifies the client-side code inside AlertUploadPanel
Using the same viewerId and only one call to MultiImageViewer for images now
ToDo: some basic cleanup left to do including fixing heights of the 2 tables
Note: The search processor currently only supports URLs, but I have some commented out code (marked with a todo) ready to accept Alert IDs as well. This should be pretty easy to enable once we have working examples of Alert IDs (and the service to call with those IDs).

Test build: Alert Viewer: https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

files you can use to test upload:
- https://web.ipac.caltech.edu/staff/roby/alert-test/al-test-2.fits
- https://web.ipac.caltech.edu/staff/roby/alert-test/coadd-1-100-thru20210505.fits

loitly

The UI still needs some polishing, which is expected. Moving the logic to the server side is a good improvement. I think we should talk offline to fully flesh out what the new interface should look like.
@robyww should review the multiProduct changes.

loitly · 2026-03-12T15:47:42Z

+    <title>Alert Viewer</title>
+
+    <script>
+        var pOpts = window.firefly && window.firefly.options || {};


loitly · 2026-03-12T15:55:59Z

+        }}>
+
+            {/* Top: tables */}
+            <Box sx={{display: 'flex', flex: '1 1 0%', gap: 1, p: 1, overflow: 'hidden', minHeight: 0, minWidth: 0,


Why is Box with display=flex used throughout? Would it be easier to use Stack?

loitly · 2026-03-12T16:09:21Z

+                            isFromURL={true}
+                            canDragDrop={false}
+                            fileAnalysis={onLoading}
+                            uploadParams={{analyzerId: 'alert'}} //triggers server alert analyzer


Not exactly what I had in mind, but I could be wrong. Let's talk offline.

loitly · 2026-03-12T16:11:02Z

            onChange: (ev) => onUrlChange(ev, viewProps, fireValueChange),
            value:  viewProps.displayValue,
-            onUrlAnalysis: (value) => doUrlAnalysis(value, fireValueChange, fileType, viewProps.fileAnalysis)
+            onUrlAnalysis: (value) => doUrlAnalysis(value, fireValueChange, fileType, viewProps.fileAnalysis, viewProps.uploadParams)


I think it could be done without having to change FileUpload.

robyww · 2026-03-20T16:38:17Z

@kpuriIpac I brought up the test. The alert tab does not appear to be enabled.

kpuriIpac · 2026-03-20T17:49:42Z

https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

@robyww can you try again? it's still working for me: https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly/alertviewer

robyww

(Mostly UI feedback with a couple of code comments. I will look at the code more on Monday.)

UI Feedback:

I think you should use the DockLayoutPanel for the three views. I think it is pretty each to use since it does layout this way by default. See line 67 of ResultsPanel.jsx
pad the right side table down so it better aligns with the left side table
remove Scroll Images: Create a prompt on MultiViewStandardToolbar to disable this features. The toolbar get all the props passed to MultiImageViewer.

robyww · 2026-03-20T16:52:15Z

+        ? {flex: '1 1 0%', minHeight: 0, height: '100%', maxWidth: '100%', overflow: 'hidden'}
+        : {width: '100%', height: '100%'};


I am surprise this change was necessary.

robyww · 2026-03-20T20:52:38Z

+                    )}
+                </Box>
+
+                <Box sx={{flex: '1 1 0%', overflow: 'hidden', minHeight: 0, minWidth: 0}}>


also I wee you adding minHeight:0, minWidth: 0. I don't see why this is necessary.

robyww · 2026-03-20T20:53:58Z

+
+    return (
+        <Stack width={1} alignItems='center'>
+            <Stack ml={0} mt={4} spacing={3} sx={{position: 'relative'}}>


why ml=0?
also since youu are declaring a sx you should put the style in there.

robyww · 2026-03-20T20:54:54Z

+                            viewerId={ALERT.IMG_VIEWER}
+                            insideFlex={true}
+                            forceRowSize={1}
+                            Toolbar={MultiViewStandardToolbar}


add the prop for MultiViewStandardToolbar here

kpuriIpac · 2026-03-24T01:09:59Z

@robyww I implemented the feedback, using DockLayoutPanel now, and cleaned up the styling a lot (unnecessary use of Box, some minHeight / minWidth - lot of it left over from my initial work & testing to make the layout work, but not really required).

One UI bug that I tried to fix today but couldn't: When you expand images (full screen) and Close the expanded mode, the images don't render (but you still see the images toolbar). If you interact with either the toolbar or either one of the tables, the images show up again. Trying to put in a fix for this soon. But otherwise the code is ready for review. Test build updated.

robyww

It looks really good! After you address my comments I think it is ready to merge.

Code

I left several clean up comments. They should be quick to address.

UI

I think the top right is 1 pixel too high
The tab should be call Alert not Upload
AlertIDDialog.jsx title should be Recent Alerts
The working mask needs to be cleaned up. It is offset.

robyww · 2026-03-24T16:54:30Z

+        if (!imageViewerId || !dataProductsState) return;
        const pv= getActivePlotView(visRoot());
        if (!pv || !hasImageCubes(pv) || cubeIdx<0) return;
        showingStatus.oldWhatToShow= whatToShow;
        showingStatus.cubeSet= false;
-    }, [whatToShow,cubeIdx]);
+    }, [whatToShow,cubeIdx,dataProductsState]);


I don't think you need to add dataProductsState here. This effect should be fine if it is undefined.

Also making it dependent on dataProductsState means the effect will run too much in the normal use case.

robyww · 2026-03-24T16:54:52Z

        const newPrimeIdx= convertHDUIdxToImageIdx(pv,hduIdx,cubeIdx) ?? 0;
        if (primeIdx!==newPrimeIdx) dispatchChangePrimePlot({plotId:pv.plotId,primeIdx:newPrimeIdx});
-    }, [table,primeIdx,cubeIdx]);
+    }, [table,primeIdx,cubeIdx,dataProductsState]);


robyww · 2026-03-24T17:47:13Z

+    }
+
+    return (
+        <Stack direction='row' flexGrow={1} overflow='hidden'>


i don't think the overflow is necessary here

robyww · 2026-03-24T17:48:20Z

+function EmptySlot({label}) {
+    return (
+        <Sheet variant='outlined'
+               sx={{height: 1, display: 'flex', alignItems: 'center', justifyContent: 'center', gcolor: 'background.level1'}}


I have never seen this? should this be here?

Yes this was a typo, also not needed. Removed.

robyww · 2026-03-24T17:53:03Z

+
+    return (
+        <Stack width={1} alignItems='center'>
+            <Stack spacing={3} sx={{position: 'relative', mt: 4}}>


often position: 'relative' is used when there is an absolute inside of it. It does not appear to be necessary.

robyww · 2026-03-24T18:06:35Z

+               File tmpFits = File.createTempFile("alert-", ".fits");
+               FileInfo fileInfo = URLDownload.getDataToFile(serviceUrl, tmpFits);
+              */
+            FileInfo fileInfo = LockingRetrieve.downloadWithCacheMsg(source);


You should check the status in fileInfo

kpuriIpac · 2026-03-24T19:12:10Z

@robyww I added a fix for images not rendering when closing expanded mode:

closing expanded mode led to image plots coming back with stale plot sizing, I think. The image plots did not get an updated viewDim, so the tiles stayed blank until any interaction triggered a layout refresh.
I thought about checking to see if a fix was possible in ImageViewerLayout when we call dispatchUpdateViewSize, but I think that is working like it's supposed to (which is why we don't see this problem elsewhere on firefly)
- The reason I think this happened here is because alert viewer renders MultiImageViewer directly in our custom results view, and may be missing an extra layout refresh that happens for standard Firefly images (like for TriView as an example)
The useEffect i added fixes that by running when the results view returns to default mode (after closing expanded mode) and explicitly calling dispatchUpdateViewSize(plotId, width, height)

Test build updated to test this fix: https://fireflydev.ipac.caltech.edu/firefly-1935-alert-viewer/firefly

I will address the rest of the feedback now.

robyww · 2026-03-24T20:52:55Z

+        }
+    },
+    menu: [
+        {label:'Upload', action: 'AlertUpload', path:'/upload'},


this line should have primary: true

kpuriIpac · 2026-03-26T02:29:39Z

@robyww I addressed the rest of your feedback (including the one in useStoreConnector we discussed on slack). Can you take a look? (I was also unsure about the fileInfo status check in the java file, let me know if what I added is what you meant). Test build is also updated. I think the masking is still a little off, will fix before merging.

robyww

Looks good. Remove the ExpanededView stuff and it is ready to merge.

robyww · 2026-03-26T16:06:16Z

+    if (expanded !== LO_VIEW.none) {
+        return (
+            <ExpandedView expanded={expanded}/>
+        );
+    }


This needs to be removed. It is not being used

robyww · 2026-03-26T16:07:35Z

+    );
+}
+
+function ExpandedView({expanded}) {


remove ExpandedView. It is not being used.

robyww · 2026-03-26T16:10:26Z

+            const nState = stateGetter(cState);      // if getter returns oldState then no state update
+            if (nState===cState || comparator(cState, nState)) return; // comparator might be overridden, use === first for efficiency
+            cState = nState;
+            if (markAsTransition) {
+                startTransition(() =>{
+                   setter(cState);
+                });
+            }
+            else {
+                setter(cState);


kpuriIpac self-assigned this Mar 3, 2026

kpuriIpac added the enhancement label Mar 3, 2026

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 6 times, most recently from 41c2af3 to cf5a5a3 Compare March 11, 2026 22:27

kpuriIpac requested a review from loitly March 11, 2026 22:30

loitly reviewed Mar 12, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 3 times, most recently from ddc105d to 97be20a Compare March 19, 2026 20:32

kpuriIpac marked this pull request as ready for review March 19, 2026 20:33

kpuriIpac requested a review from robyww March 19, 2026 20:55

robyww reviewed Mar 20, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch 6 times, most recently from 518377d to 0a657fa Compare March 24, 2026 01:06

robyww approved these changes Mar 24, 2026

View reviewed changes

robyww reviewed Mar 24, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch from e2711a3 to e85ac0d Compare March 25, 2026 19:23

robyww reviewed Mar 26, 2026

View reviewed changes

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch from 81311c4 to 59418f3 Compare March 26, 2026 17:53

FIREFLY-1935: Implement Alert Viewer

d77417f

kpuriIpac force-pushed the FIREFLY-1935-alert-viewer branch from 59418f3 to d77417f Compare March 26, 2026 18:29

kpuriIpac merged commit 6e888d5 into dev Mar 26, 2026

kpuriIpac deleted the FIREFLY-1935-alert-viewer branch March 26, 2026 18:30

robyww added this to the 2026.1 milestone Apr 22, 2026

		? {flex: '1 1 0%', minHeight: 0, height: '100%', maxWidth: '100%', overflow: 'hidden'}
		: {width: '100%', height: '100%'};

Conversation

kpuriIpac commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loitly left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robyww commented Mar 20, 2026

Uh oh!

kpuriIpac commented Mar 20, 2026

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

UI Feedback:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Mar 24, 2026

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

Code

UI

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpuriIpac commented Mar 26, 2026

Uh oh!

robyww left a comment

Choose a reason for hiding this comment

Uh oh!

robyww Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kpuriIpac commented Mar 3, 2026 •

edited

Loading

kpuriIpac commented Mar 24, 2026 •

edited

Loading

robyww Mar 26, 2026 •

edited

Loading