Firefly-1958: new URI(s).toURL() is not backward compatable to new URL#1923
Merged
Firefly-1958: new URI(s).toURL() is not backward compatable to new URL#1923
Conversation
Contributor
|
Yes, it works! |
loitly
approved these changes
Mar 18, 2026
Contributor
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
It worked for me as well. Changes look good.
|
|
||
| public static URL makeURL(String s) { | ||
| if (s == null) return null; | ||
| URL url= Util.Try.it(() -> new URI(s.trim()).toURL()).getOrElse((URL)null); |
Contributor
There was a problem hiding this comment.
The idea was to make the code more readable. It was intended to be used like:
URL url= Try.it(() -> new URI(s.trim()).toURL()).get();It defaults to null if failed.
…L(s) - clean up TapUtil.js, all url build consistently with new URL() - other clean up of tap utilities as well - Firefly-1956: fixed
robyww
force-pushed
the
FIREFLY-1958-url
branch
from
fb473fa to
e07f33f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1958: new URI(s).toURL() is not backward compatible to new URL
Testing