FIREFLY-1942: Add a new box mode to Search Select Tools in EmbeddedPositionSearchPanel#1925
Merged
jaladh-singhal merged 2 commits intodevfrom Mar 30, 2026
Merged
Conversation
jaladh-singhal
added
enhancement
UI
jaladh-singhal
commented
Mar 25, 2026
| const rotAxisWp = plot.attributes[PlotAttribute.USER_SEARCH_BOX_AXIS_WP]; | ||
| if (!wp || !wpAry) return []; | ||
|
|
||
| // TODO: draw rotate and resize handles when the box is selected (similar to footprint selection behavior) |
Member
Author
There was a problem hiding this comment.
@robyww I plan to do this in another ticket in the future - will make one when merging this one.
jaladh-singhal
commented
Mar 25, 2026
jaladh-singhal
force-pushed
the
FIREFLY-1942-rotation-rect-select
branch
from
60df5a2 to
2a92133
Compare
robyww
approved these changes
Mar 26, 2026
Contributor
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
You did a really go job on this! I know it was a lot of effort. The code is clean and I like the additional cleanup and documentation you did.
I left a few very small comments but after you clean that up I think it is ready.
jaladh-singhal
commented
Mar 27, 2026
FIREFLY-1942: Update signature of updatePlotOverlayFromUserInput() Add code comments for clarity FIREFLY-1942: Rename selection source constant for search refinement tool FIREFLY-1942: Add/update comments in drawing layer files for clarity FIREFLY-1942: Add Box search input fields and search select tool for HiPS FIREFLY-1942: Add a useBox plot attribute and change projection center in convertBoxToSelection FIREFLY-1942: Use constants for min and max size values in EmbeddedPositionSearchPanel FIREFLY-1942: Add rectangle rotation angle in getDetailsFromSelection FIREFLY-1942: Refactor BoxSearchInputFields to use dynamic labels and improve layout FIREFLY-1942: Add SelectAreaForEmbedded in Box search input fields FIREFLY-1942: Add numeric inc/dec controls to rotation field FIREFLY-1942: Add rotation axis world point to selection attributes and refactor related calculations FIREFLY-1942: Fix box drawing errors at poles by computing polygon corners FIREFLY-1942: clarify getDetailsFromSelection produce all WorldPts in Equatorial FIREFLY-1942: Cleanup todos and logs FIREFLY-1942: Refactor updateUIFromPlot by extracting each case into separate functions FIREFLY-1942: Make box UI input more overridable FIREFLY-1942: Apply feedback from the PR FIREFLY-1942: Add logs for box DL FIREFLY-1942: Fix search summary not showing when single toggle option FIREFLY-1942: Update convertBoxToSelection to use wpAry FIREFLY-1942: Remove box from DCE
jaladh-singhal
force-pushed
the
FIREFLY-1942-rotation-rect-select
branch
from
1019ba9 to
ffe89b6
Compare
jaladh-singhal
force-pushed
the
FIREFLY-1942-rotation-rect-select
branch
from
ffe89b6 to
4ea7e4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-1942
EmbeddedPositionSearchPanelto support a "Box" search type and added theBoxSearchInputFieldscomponent for user input of box size and rotationSearchSelectToolto support boxes: addeddrawSearchSelectionTransformBoxfor rendering box shapes with rotationVisualSearchUtilsandTargetHiPSPanelto support bidirectional update between HiPS image + drawing layer and box UI inputs.Other Improvements
QuantityInputFieldto allow passing additional props for customizing the numeric input, supporting features like increment/decrement controls for rotation.Fixed a regression bug that was failing Spectral Image search tab to load in SPHERExrebased from devAlso see IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/460
Testing
Enable direction and grid layers on HiPS for testing. Zoom in the HiPS to FOV < 8 deg since there's upper limit on box size. Then:
Do above testing for target at a 1) random location (
34, -56), 2) near equator (anything 0), 3) at poles (0 90,0 -90). Also try changing projection (spherical/aitoff), and coordinate system (galactic/equatorial) of the HiPS.Regression Testing
Check if the following are working as before: