Firefly-1963: revamp of asdf code to use an factor approach#1926
Conversation
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
The provided URLs did not work for me. The sample files in the tickets worked as described.
| public static final String STATS_LOG_DIR= "stats.log.dir"; | ||
|
|
||
|
|
||
| private final static String cloudEnvironmentDefault = System.getProperty("cloud.environment", "detect"); // can be "GWS", "AWS", "ON_PRIM" or "detect" |
There was a problem hiding this comment.
GWS should be GCP and ON_PRIM should be ON_PREM
There was a problem hiding this comment.
I will fix the ON_PRIM to ON_PREM. I will also change the CloudEnvironment enum to GCP
The GWS is a mistake. However I am using GCS everywhere which stands for Google Cloud Storage. I think the difference in the case is not a big deal since we are accessing Google Cloud Storage.
|
|
||
| static { | ||
| Asdf.configure((b) -> { | ||
| File asdfTmp= new File(ServerContext.getTempWorkDir(), "asdfTemp"); |
There was a problem hiding this comment.
It's already in a temp work directory. Just asdf would be good enough.
| } | ||
| else { | ||
| report.setMessage("Unrecognized version of ASDF file"); | ||
| } |
There was a problem hiding this comment.
I’m not sure, but it seems this project-specific logic(ROMAN) could live in DataAccessModel and ModelFactory, so it doesn’t have to be scattered elsewhere.
robyww
force-pushed
the
FIREFLY-1963-asdf
branch
from
b31ad1d to
a194c82
Compare
|
The sample url were not to enter into firefly but box directories to get files. |
- better feedback when the type of asdf file is not recognized - some support for IPAC roman asdf files - upgrade the asdf library - now asdf temp files goto temp_files/asdfTemp - includes reponse to feedback
robyww
force-pushed
the
FIREFLY-1963-asdf
branch
from
a194c82 to
48870fa
Compare
2 participants
Firefly-1963: revamp of asdf code to use an factor approach
Testing