Skip to content

IRSA-7653: Fix precision handling for SizeInputField causing round-trip errors#1928

Merged
jaladh-singhal merged 1 commit intodevfrom
IRSA-7653-integrate-mosaic-uws
Apr 2, 2026
Merged

IRSA-7653: Fix precision handling for SizeInputField causing round-trip errors#1928
jaladh-singhal merged 1 commit intodevfrom
IRSA-7653-integrate-mosaic-uws

Conversation

@jaladh-singhal
Copy link
Copy Markdown
Member

See IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/461

  • Unlike WavelengthInputField, SizeInputField wasn't calculating precision (number of digits after decimal) based on each unit. Fixed it.
  • Also added precision based rounding to min and max bounds to prevent errors in bound validation due to floating point comparison (esp when arcsec is converted to base unit degree and then compared)

@jaladh-singhal jaladh-singhal added this to the 2026.1 milestone Apr 1, 2026
@jaladh-singhal jaladh-singhal requested review from loitly and robyww April 1, 2026 20:56
@jaladh-singhal jaladh-singhal self-assigned this Apr 1, 2026
Copy link
Copy Markdown
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread src/firefly/js/util/MathUtil.js
@jaladh-singhal jaladh-singhal merged commit af4152f into dev Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants