Skip to content

FIREFLY-1976: UwsJobProcessor need to handle zip encoding#1931

Merged
loitly merged 1 commit intodevfrom
FIREFLY-1976-vizier-uws-phase
Apr 9, 2026
Merged

FIREFLY-1976: UwsJobProcessor need to handle zip encoding#1931
loitly merged 1 commit intodevfrom
FIREFLY-1976-vizier-uws-phase

Conversation

@loitly
Copy link
Copy Markdown
Contributor

@loitly loitly commented Apr 7, 2026

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1976

3 items:

  1. VizieR ADQL stuck in QUEUE
  • The TAP service returns job info as a gzip-encoded response
  • Add gzip handling support in UwsJobProcessor
  1. HEASARC TAP query failure
  • The TAP service returns a relative href in the results block
  • Ignore the provided href and consistently use /results/result for all TAP jobs
  1. Generate Helm documentation
  • Use helm-docs to generate helm/README.md
  • Provides simple, consistent documentation

Test: https://fireflydev.ipac.caltech.edu/firefly-1976-vizier-uws-phase/firefly/
Follow ticket instruction to test the 2 bugs.

For helm-docs generated readme, see README.md

@loitly loitly added this to the 2026.1 milestone Apr 7, 2026
@loitly loitly requested a review from robyww April 7, 2026 15:46
@loitly loitly self-assigned this Apr 7, 2026
@loitly loitly added the bug label Apr 7, 2026
- HEASARC TAP returned relative URL.  Use /results/result for all TAP services to avoid bad results block
- use helm-docs to auto-generate helm/README.md file.
@loitly loitly force-pushed the FIREFLY-1976-vizier-uws-phase branch from d39e713 to 56f7852 Compare April 7, 2026 15:53
@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Apr 7, 2026

I am trying the specific steps that led me to the error in the first place, and I get:

Table Error
Cause:
Job has failed with the error: IO error while reading the VOTable of "upload_table"!

I'll grant you this is a different error!

If I try a specific target, I get:

Table Error
Cause:
Job has failed with the error: Incorrect ADQL query: Encountered "CONTAINS". Was expecting one of: "(" "NOT"
"EXISTS" "+" "-" "ABS" "CEILING" "DEGREES" "EXP" "FLOOR" "LOG" "LOG10" "MOD" "PI" "POWER" "RADIANS" "RAND" "ROUND" "SQRT" "TRUNCATE" "ACOS" "ASIN" "ATAN" "ATAN2" "COS" "COT" "SIN" "TAN" "AREA" "COORD1" "COORD2" "DISTANCE" <REGULAR_IDENTIFIER_CANDIDATE> <SCIENTIFIC_NUMBER> <UNSIGNED_FLOAT> <UNSIGNED_INTEGER> """ "COUNT" "AVG" "MAX" "MIN" "SUM" "COORDSYS" "'" "BOX" "CENTROID" "CIRCLE" "POINT" "POLYGON" "REGION" (HINT: "CONTAINS" is a reserved ADQL word. To use it as a column/table/schema name/alias, write it between double quotes.)

Again, at least it is a different error, but it is still not working.

@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Apr 7, 2026

I can read the Helm page so I'm assuming that's good to go.

A query of "m101" to HEASARC TAP comes back successfully.

A query of other VizieR tables (not the one specified in my original complaint, but ones I know cover M101) result in similar errors as I mention above. So I think it's still broken.

Copy link
Copy Markdown
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@loitly loitly merged commit bc17a40 into dev Apr 9, 2026
@loitly loitly deleted the FIREFLY-1976-vizier-uws-phase branch April 9, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants