Conversation
jaladh-singhal
requested changes
Apr 21, 2026
Member
There was a problem hiding this comment.
this doesn't let MultiImageViewer render if there is an array of IDs with no PlotView (id in plotViewAry) but Proxy (id in plotProxyAry).
Maybe we should define a getPlotProxy() and || it here
| activePlotId: null, | ||
| plotViewAry : [], //there is one plot view for every ImageViewer, a plotView will have a plotId | ||
| plotGroupAry : [], // there is one for each group, a plot group may have multiple plotViews | ||
| plotProxyAry : [], //there is one plot view for every ImageViewer, a plotView will have a plotId |
Member
There was a problem hiding this comment.
this comment needs to explain plot proxy, not plot view
Comment on lines
+117
to
+123
| export function ImageViewerProxy({fromWorkingTask=false, ...props}){ | ||
| return fromWorkingTask | ||
| ? <ImageViewerWorkingTaskTask {...props}/> | ||
| : <ImageViewerMessageProxy {...props}/>; | ||
| } | ||
|
|
||
| export function ImageViewerMessageProxy({plotId,message,children}){ |
Member
There was a problem hiding this comment.
I feel like we are overusing proxy here - it's fine in state logic. I found it hard to follow here. Maybe consider renaming:
ImageViewerProxy->ImageViewerPlaceholder(placeholder for proxy entity or a working task)ImageViewerMessageProxy->ImageViewerProxyMessage(proxy entity that has a message)
Contributor
Author
There was a problem hiding this comment.
ok, I think I had it name something like that before.
robyww
force-pushed
the
FIREFLY-1995-proxy
branch
from
88513ee to
ba31dea
Compare
jaladh-singhal
approved these changes
Apr 21, 2026
Member
jaladh-singhal
left a comment
jaladh-singhal
left a comment
There was a problem hiding this comment.
Thanks for the changes. It's working now!
robyww
force-pushed
the
FIREFLY-1995-proxy
branch
from
ba31dea to
5954118
Compare
- fixed: Firefly-1993 - cutouts seem misrepresented - fixed: Firefly-1996 - parsing cerntain type of targets cause crash, improved parsing - inclues response to feedback
robyww
force-pushed
the
FIREFLY-1995-proxy
branch
from
5954118 to
0ae6f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1995: support a image view proxy
Testing