Skip to content

DM-16476: Create a TableTypeWatcher to support monitoring tables for full life time#737

Merged
robyww merged 1 commit intodevfrom
DM-16476-master-watcher
Feb 6, 2019
Merged

DM-16476: Create a TableTypeWatcher to support monitoring tables for full life time#737
robyww merged 1 commit intodevfrom
DM-16476-master-watcher

Conversation

@robyww
Copy link
Copy Markdown
Contributor

@robyww robyww commented Feb 1, 2019 •
edited
Loading

Create a TableTypeWatcher to support monitoring tables for full life time

  • Add TypeTypeWatcher system to MasterSaga
  • Modified three watchers for new system: CatalogWatcher, ImageMetaDataWatcher, CoverageWatcher
  • Added more testing
  • fixed ibeQuery attributes, finished ImageMetaDataWatcher
  • CoverageWatcher fix to filter out duplicates for query columns (from tatiana)
  • includes fixed IRSA-2568
  • a little cleanup of DrawLayerCntlr, removed unused action
  • Added viewer test and new viewer test category

To test:

https://irsawebdev9.ipac.caltech.edu/DM-16476-master-watcher/firefly/
https://irsawebdev9.ipac.caltech.edu/DM-16476-master-watcher/firefly/firefly-dev.html
https://irsawebdev9.ipac.caltech.edu/DM-16476-master-watcher/firefly/test/tests-main.html

  • Since this is a refactor ticket. Everything should work life before.
  • Run 1: bring up some images at a target then load a catalog. Should see the overlay.
  • Run 2: start with catalog and do search should see the coverage like before
  • Run 3:
    • load firefly-dev.html
    • Test Searches => Wise Search => Any pixel overlaps search region => 5.1 deg => AllWise
    • Should see wise coverage and wise metadata tags
  • Run 4: load firefly/test/tests-main.html, confirm test 5 is correct.

@robyww robyww self-assigned this Feb 1, 2019
@robyww robyww requested a review from loitly February 1, 2019 19:37
@robyww robyww force-pushed the DM-16476-master-watcher branch 2 times, most recently from 6c88d9b to 3097a58 Compare February 1, 2019 23:03
loitly
loitly requested changes Feb 2, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@loitly loitly left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. There is one regression bug I found. It would be nice to be able to fix it.
Also, I see an excludes list that one can pass along with dispatchAddTableTypeWatcherDef.
But, let's say HydraViewer add a catalogWatcherDef. How do user of Hydra's template excludes catalogWatcher completely? Is there a way to remove the watchers you don't want?

These bugs(?) I found while testing. Ignore the ones that's already filed.

regression bug:

Images -> m8 -> WISE ALLWISE -> Search
Catalogs -> cones -> m8 -> 200 arcsec -> Search

  • no image is selected/focused
  • select an image, then sort table
    • focus is lost.. image will lost focus on every table load
    • if there were multiple tabs, switching tabs would remove image focus as well.

existing bugs:

catalog search: WISE any coord size

  • bring up layer dialog, turn on/off a couple
  • switch to HiPS, dialog changed.. good
  • switched back to FITS, it didn't bring back previous dialog.
  • clicking on some of the options cause Errors in console.

coverage loses position when switching back to fits

  • catalog -> m31, 300 arcsec -> search
    • switch coverage to fits.. coverage is in center.. need to zoom out to see the overlay
  • catalog -> m51, 300 -> search
    • HiPS correctly shows 2 patches
    • switch to fits, coverage is somewhere in the middle, which is bad.. no data to overlay

Comment thread src/firefly/js/visualize/saga/CatalogWatcher.js
@robyww
Copy link
Copy Markdown
Contributor Author

robyww commented Feb 4, 2019

coverage loses position when switching back to fits
catalog -> m31, 300 arcsec -> search
switch coverage to fits.. coverage is in center.. need to zoom out to see the overlay
catalog -> m51, 300 -> search
HiPS correctly shows 2 patches
switch to fits, coverage is somewhere in the middle, which is bad.. no data to overlay

This is not a bug. The switch to fits it suppose to make a fits where ever the HiPS is centered at. If you think about it there is not much else to do. Besides, that it give you use to look more closely at what every spot they choose.

@robyww
Copy link
Copy Markdown
Contributor Author

robyww commented Feb 4, 2019

catalog search: WISE any coord size
bring up layer dialog, turn on/off a couple
switch to HiPS, dialog changed.. good
switched back to FITS, it didn't bring back previous dialog.
clicking on some of the options cause Errors in console.

I can duplicate this. I am probably going. I tried in several ways. Must be some other small step that I am missing.

@robyww
Copy link
Copy Markdown
Contributor Author

robyww commented Feb 4, 2019 •
edited
Loading

regression bug:

found it and will fix it. thanks.

@robyww
DM-16476: Create a TableTypeWatcher to support monitoring tables for …
b11fc43 
…full lifetime

 - Add TypeTypeWatcher system to MasterSaga
 - Modified three watchers for new system: CatalogWatcher, ImageMetaDataWatcher, CoverageWatcher
 - fixed ibeQuery attributes, finished ImageMetaDataWatcher
 - CoverageWatcher fix to filter out duplicates for query columns (from tatiana)
 - includes fixed IRSA-2568
 - a little cleanup of DrawLayerCntlr, removed unused action
 - Added more testing, new test, and second test catagory
 - refactored code to remove getCenterColumns and use VOAnalyzer.findTableCenterColumns
 - updated JSDocs for findTableCenterColumns
 - fix regression bug with plots losing focus
 - added way to modify or disable watcher def
 - organization of feature watchers
@robyww robyww force-pushed the DM-16476-master-watcher branch from 8115ecf to b11fc43 Compare February 6, 2019 20:05
@robyww robyww merged commit 2cc6648 into dev Feb 6, 2019
@robyww robyww deleted the DM-16476-master-watcher branch February 6, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loitly loitly loitly approved these changes

Assignees

@robyww robyww

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robyww @loitly