FIREFLY-362-LowerLimits fix the text shown in the tooltip of upward pointing arrows for lower limit on Y axis values in scatter plots #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ointing arrows for lower limit on Y axis values in scatter plots
robyww
approved these changes
Jun 29, 2020
Contributor
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
Looks fine. My only question is why check for null and not undefined, Maybe you should use isNil?
Contributor
Author
|
@robyww I saw it is a list with either null or number. but it will be good to use isNil. Thanks. |
…tent in FireflyGenericData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update for
https://jira.ipac.caltech.edu/browse/FIREFLY-362
test:
https://fireflydev.ipac.caltech.edu/firefly-362-lowerlimits/firefly/test/tests-chart.html
please look at the 3rd chart with both upward and downward pointing arrows. 'Upper Limit' or 'Lower Limit' should be shown at the last line in the tooltip box respectively for downward or upward pointing arrows.