Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented Jul 31, 2024

No description provided.

@bsipocz bsipocz added the content Content related issues/PRs. label Jul 31, 2024
@bsipocz bsipocz force-pushed the CONT_adding_firefly branch from d6506fc to dcab026 Compare August 1, 2024 01:30
@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2024

Both these notebooks work for me locally on OSX, so I'm puzzled if the issues we see in CI are expected or not.

cc @jaladh-singhal in case you have any tips or insights of what is going wrong.

@jaladh-singhal
Copy link
Member

cc @jaladh-singhal in case you have any tips or insights of what is going wrong.

@bsipocz this gaierror: [Errno 8] nodename nor servname provided, or not known has been observed by me, Eric, and others randomly - it's hard to reproduce consistently. It's interesting to see that it's happening only on MacOS pipeline.

A quick google search and chasing SO threads, reveals that it has to do with requirement of explicit defining of hosts/port name for MacOS (but I can be wrong). I'll open a bug ticket about it at firefly-client so that we can remember to debug it.

Comment on lines +17 to +18
# For firefly-client packaging bug
setuptools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we need to fix at package configuration of firefly-client by defining setuptools as required dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap, see Caltech-IPAC/firefly_client#60, as well as the other pkg_resources related issue. In fact addressing Tim's would make this one irrelevant, too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't notice that - thanks. I'll get this added to Jira

Comment on lines 13 to 14
firefly_client
jupyter_firefly_extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't help but notice: the pip packages names for both of these use - instead of _ - I ran into similar confusion earlier and couldn't install the package, I'm surprised to see it's working in CI with _

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahh, interesting. I suppose pip replaces them at install, but indeed I should declare them as they are named on pypi.

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2024

@bsipocz this gaierror: [Errno 8] nodename nor servname provided, or not known has been observed by me, Eric, and others randomly - it's hard to reproduce consistently. It's interesting to see that it's happening only on MacOS pipeline.

It seems to be pretty consistent on CI, but I also don't see it locally on OSX, everything works there for me when I directly use the notebooks.
So, is there a workaround recipe that you would suggest us to do here? I mean, the easiest would be to just exclude these tutorials from the OSX testing for now and comment in a reference for a known firefly issue.

@jaladh-singhal
Copy link
Member

jaladh-singhal commented Aug 1, 2024

So, is there a workaround recipe that you would suggest us to do here? I mean, the easiest would be to just exclude these tutorials from the OSX testing for now and comment in a reference for a known firefly issue.

Yes, I would suggest excluding these (or anything under firefly/) for now. I have other stuff on my plate so I won't get chance to work on it until late August.

Ubuntu and Windows pipelines passing is good enough check, I think?

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2024

Ubuntu and Windows pipelines passing is good enough check, I think?

Well, not if we want to ensure things are working for mac users, too, but for now I'll indeed turn off that job for that directory.

@bsipocz bsipocz force-pushed the CONT_adding_firefly branch 2 times, most recently from 4f9a704 to 65997f3 Compare August 1, 2024 22:32
@bsipocz bsipocz force-pushed the CONT_adding_firefly branch from 65997f3 to 5abf9f1 Compare August 1, 2024 22:40
@bsipocz bsipocz merged commit db88c78 into Caltech-IPAC:main Aug 1, 2024
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
@bsipocz bsipocz mentioned this pull request Aug 21, 2024
@bsipocz bsipocz deleted the CONT_adding_firefly branch August 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Content related issues/PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants