-
Notifications
You must be signed in to change notification settings - Fork 6
CONT: adding firefly tutorials #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6506fc to
dcab026
Compare
|
Both these notebooks work for me locally on OSX, so I'm puzzled if the issues we see in CI are expected or not. cc @jaladh-singhal in case you have any tips or insights of what is going wrong. |
@bsipocz this A quick google search and chasing SO threads, reveals that it has to do with requirement of explicit defining of hosts/port name for MacOS (but I can be wrong). I'll open a bug ticket about it at firefly-client so that we can remember to debug it. |
| # For firefly-client packaging bug | ||
| setuptools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we need to fix at package configuration of firefly-client by defining setuptools as required dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeap, see Caltech-IPAC/firefly_client#60, as well as the other pkg_resources related issue. In fact addressing Tim's would make this one irrelevant, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, didn't notice that - thanks. I'll get this added to Jira
tutorials/requirements.txt
Outdated
| firefly_client | ||
| jupyter_firefly_extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't help but notice: the pip packages names for both of these use - instead of _ - I ran into similar confusion earlier and couldn't install the package, I'm surprised to see it's working in CI with _
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahh, interesting. I suppose pip replaces them at install, but indeed I should declare them as they are named on pypi.
It seems to be pretty consistent on CI, but I also don't see it locally on OSX, everything works there for me when I directly use the notebooks. |
Yes, I would suggest excluding these (or anything under Ubuntu and Windows pipelines passing is good enough check, I think? |
Well, not if we want to ensure things are working for mac users, too, but for now I'll indeed turn off that job for that directory. |
4f9a704 to
65997f3
Compare
65997f3 to
5abf9f1
Compare
CONT: adding firefly tutorials db88c78
No description provided.