CI: enable firefly osx #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is super low stake (we do run the tests with the linux VM), so I'll just wait for the new release before merging this. |
Member
|
Yeah, I'm about to create a PR to improve package infrastructure a bit and then I'll cut a release probably sometime next week. On a related thought, can you trigger your pipeline once I have that upcoming PR merged for a final test? |
Member
Author
Sure, and I'm also happy to trigger it on your PR before merging it. |
bsipocz
force-pushed
the
CI_enable_firefly_osx
branch
from
ae679c2 to
00a0d47
Compare
Member
Author
|
Ahh, this smoked out a bug in the new CI system :) |
tutorials/requirements.txt
Outdated
| ray | ||
| s3fs | ||
| firefly-client | ||
| git+https://github.com/Caltech-IPAC/firefly_client@FIREFLY-1527-update-package-config#egg=firefly_client |
Member
There was a problem hiding this comment.
This can now safely go back to firefly-client. Thanks for all the testing!
bsipocz
force-pushed
the
CI_enable_firefly_osx
branch
from
1154f3a to
3951399
Compare
Member
|
Great! all checks passed |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
CI: enable firefly osx ff38f99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to test the fix from Caltech-IPAC/firefly_client#61
More context: #10 (comment) and below
cc @jaladh-singhal