BUG: avoid QTable convertint int columns to float#90
Merged
bsipocz merged 1 commit intoCaltech-IPAC:mainfrom Apr 1, 2025
Merged
BUG: avoid QTable convertint int columns to float#90bsipocz merged 1 commit intoCaltech-IPAC:mainfrom
bsipocz merged 1 commit intoCaltech-IPAC:mainfrom
Conversation
Member
Author
|
Merging this as tests passed and I expect rendering to work for the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't plot from
result_table, so we don't strictly require it to be aQTable.So, this is a reasonable workaround while the upstream issues astropy/astropy#17963 and the
NAunit from the DB side are resolved.Also, note that we see the values changed in the table during the conversions, which I still need to investigate and open relevant upstream bug reports for.