fix: typo in search for 'combined.bpc' in pck cache files#197
Merged
Conversation
Problem: there is a typo in the filename being searched for in the list of PCK files in the cache which have .bpc extension. The correct search string is: combined.bpc (not combined.bsp). Issue: IPAC-SW/kete#15
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an incorrect filename substring check when detecting whether the NAIF “combined” PCK (*.bpc) is already present in the local kernel cache, preventing unnecessary re-download attempts. This aligns behavior with the actual .bpc extension used for cached PCK files and addresses issue #15.
Changes:
- Corrects the cache filename check from
combined.bsptocombined.bpcwhen scanning cached*.bpcfiles. - Bumps project version from
1.1.2to1.1.3. - Adds an additional author entry in
pyproject.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/kete/spice.py |
Fixes the cached PCK “combined” filename substring check to use .bpc, avoiding unnecessary download logic. |
pyproject.toml |
Updates package metadata (version bump and authors list). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bump both versions Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: there is a typo in the filename being searched for in the list of PCK files in the cache which have .bpc extension.
The correct search string is: combined.bpc (not combined.bsp).
Issue: https://github.com/IPAC-SW/kete/issues/15