daemon client reliability#438
Merged
Merged
Conversation
prkrtg
approved these changes
May 19, 2026
…ble abort Three bugs in the slicecam/acam startup retry loops and DaemonClient::send: sequence.cpp — slicecam_init and acam_init retry loops: - Missing break in the else (exceeded-max-attempts) branch caused attempt <= maxattempts (3 <= 3) to remain true forever, spinning indefinitely through power-on and connect cycles. - No disconnect() in that branch left the socket open to a busy slicecamd; subsequent connect_to_daemon() calls skipped reconnect because isconnected() was still true, allowing delayed replies from the previous timed-out open command to accumulate in the receive buffer. - No cancel_flag check anywhere in either loop meant abort_process() could not interrupt a stuck startup. common.cpp — DaemonClient::send(): - On CID mismatch, drain the socket receive buffer with Poll(0) before returning ERROR so stale replies cannot bleed into the next send() call, independent of whether the caller reconnects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: sequencerd sending commands to camerad
add a correlation ID to inter-daemon messages
DaemonClient::send retries only on stale fd
increase timeout for camerad activate command