Hotfix/may20#443
Merged
Merged
Conversation
remove legacy telemetry from camerad
(these are required for commit ca90f1 to run)
astronomerdave
force-pushed
the
hotfix/may20
branch
from
4db2273 to
dfe3c61
Compare
scizen9
approved these changes
May 28, 2026
scizen9
left a comment
scizen9
left a comment
There was a problem hiding this comment.
Check the impact on previous PRs, but otherwise, approved.
* fix: thermald pub-sub handling with:
- thermald handles external data with a single function
- adds db_column_defs.h to remove confusion between
message keys and database fields
* fix: Sequence::shutdown error incorrectly initialized, which
would return ERROR on success.
* fix: Sequence::shutdown bound slit_shutdown to ACAM tag,
and vice-versa
* move tcs_shutdown to the end of the shutdown sequence
to avoid errors from daemons still talking to it
* replace hard-coded strings in slicecamd with message keys
* publish acam temp on temp topic instead of status topic
* acam shutdown shuts down camera before motion
* acam publishes final status on close
* adds message keys for TANDOR_*
* updates targetcontrol.py to use "poll" command when talking
to tcs, to avoid excess logging
affects focus, flexure, and tcs
meant that a thread could close somone elses's fd. This
touches a lot of files but it's a single charactor to pass
by referece.
state tracking and recovery. Until I can implement ZMQ REQ/REP I am switching DaemonClient to per-command connections so each command opens, sends, and closes its own connection.
astronomerdave
force-pushed
the
hotfix/may20
branch
from
947cc17 to
0cb78b0
Compare
not being routed to the tcs on subsequent restarts.
fix: increase ACAMD_MOVE_TIMEOUT (was timing out during moves)
init_log()'s return was ignored in every daemon. If it failed it wouldn't retry until 24 hours later. This retries every 60s and writes to stderr. Might not have been a big problem but worth fixing.
On a database fault, dothread_telemetry threw on connect, logged ERROR, and terminated; the 1Hz telemetry_watchdog respawned it immediately, producing a ~1Hz connect-storm and ERROR-log spam for the duration of the outage. This adds a backoff counter that doubles on each failed attempt (30s max) and resets on a successful connection.
fix: tcs emulator didn't recognize "Z" update: reduce tcs logging on polling
astronomerdave
force-pushed
the
hotfix/may20
branch
from
678b8cc to
29cf6f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipin' hot!
these are all the fixes we had to put in last night, needed to make ngps work