fixed Rectangle::setHeight()#40
Merged
RyanVreeke merged 1 commit intoCalvin-CS:masterfrom Jul 1, 2021
Merged
Conversation
setHeight() updated the width instead of the height of the rectangle...
Contributor
|
Merging since its been tested and a ppa package is going to be created. |
RyanVreeke
pushed a commit
to RyanVreeke/TSGL
that referenced
this pull request
Jul 16, 2021
Updated wiki and tutorials for TSGL 2D and 3D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setHeight() updated the width instead of the height of the rectangle...
discovered this bug while debugging with getHeight(), which produced improper results