Skip to content

Wait for any output instead of default prompt on startup#357

Merged
blink1073 merged 1 commit intoCalysto:mainfrom
blink1073:improve-startup
Mar 10, 2026
Merged

Wait for any output instead of default prompt on startup#357
blink1073 merged 1 commit intoCalysto:mainfrom
blink1073:improve-startup

Conversation

@blink1073
Copy link
Copy Markdown
Contributor

@blink1073 blink1073 commented Mar 10, 2026

Summary

  • Fixes startup failure when the user has a custom prompt that doesn't match prompt_regex
  • Instead of self.child.expect(prompt_regex) in set_prompt (which times out with custom prompts), wait for any characters to be printed ([\s\S]+) before sending the prompt change command
  • This is a reimplementation of Do no wait for the default prompt on startup #286 that fixes the root cause rather than skipping the wait entirely

Closes #286

Test plan

  • Verify existing tests pass: just test
  • Manually test with a kernel that uses a custom REPL prompt to confirm no startup timeout

Fixes startup failure when the user has a custom prompt that doesn't
match the default prompt_regex: instead of timing out waiting for a
specific pattern, wait for any characters to be printed before sending
the prompt change command.
@blink1073 blink1073 added the bug label Mar 10, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.95%. Comparing base (63d79b8) to head (887075e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files          51       51           
  Lines        2874     2874           
  Branches      402      402           
=======================================
  Hits         2614     2614           
  Misses        181      181           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blink1073 blink1073 merged commit a07f489 into Calysto:main Mar 10, 2026
28 checks passed
@blink1073 blink1073 deleted the improve-startup branch March 10, 2026 17:42
@blink1073 blink1073 mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants