Add ruff S (flake8-bandit) security checks#383
Merged
blink1073 merged 1 commit intoCalysto:mainfrom Mar 15, 2026
Merged
Conversation
Enables the S rule set in ruff lint configuration. Rules inherent to a kernel/REPL system (exec, eval, subprocess, URL open) are globally suppressed; assert and temp-file warnings are suppressed in tests; and remaining intentional patterns are annotated with inline noqa comments.
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (89.47%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 51 51
Lines 2957 2957
Branches 414 414
=======================================
Hits 2687 2687
Misses 190 190
Partials 80 80
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Enables the
S(flake8-bandit) rule set in the ruff lint configuration to surface security-relevant patterns across the codebase.Changes
"S"toextend-selectin[tool.ruff.lint]S102(exec),S307(eval),S310(URL open),S603(subprocess),S604(false positive onshell=dict key),S607(partial executable path)S101andS108totests/**per-file-ignores (asserts and temp files are normal in tests)# noqacomments for intentional patterns in source:S110/S112(deliberate silent exception handling),S101(type-narrowing asserts),S103(intentional chmod modes)Backwards-incompatible changes
None
Testing
just pre-commitpasses cleanly.AI usage