Fix release job crash when dev version bump is a no-op#413
Merged
blink1073 merged 1 commit intoCalysto:mainfrom Mar 22, 2026
Merged
Fix release job crash when dev version bump is a no-op#413blink1073 merged 1 commit intoCalysto:mainfrom
blink1073 merged 1 commit intoCalysto:mainfrom
Conversation
When releasing an rc version, bump_dev.py returns the version unchanged, so poetry version has nothing to modify and git commit fails on "nothing to commit". Guard the commit with a git diff --staged --quiet check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
#411
Description
When releasing an
rcversion (e.g.1.0.0rc5),bump_dev.pyintentionally returns the version unchanged because it already has a pre-release suffix. This meanspoetry versionmakes no modification topyproject.toml, sogit commitexits with code 1 on "nothing to commit". Withset -eactive in the shell environment, this crashes the release job.Changes
action.ymlwithgit diff --staged --quiet; skip the commit (and push) silently when there are no staged changes.Backwards-incompatible changes
None
Testing
Dry-run release workflow triggers this code path with rc versions.
AI usage