Start Xvfb globally in action instead of per-command#269
Merged
Conversation
Move Xvfb startup into the composite GitHub Action so it runs once for all Linux jobs, removing the need for xvfb-run wrappers on each test command. Also add graphics toolkit verification to the octave install check step and rename "Install octave" steps to "Setup octave".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
action.yml) so it runs once globally for Linux, settingDISPLAY=:99in the environmentxvfb-run --auto-servernumwrappers from test steps in the CI workflowavailable_graphics_toolkitsverification to the octave install check stepTest plan