Fix do_shutdown coroutine warning and improve console UX#280
Merged
Conversation
- Replace unawaited do_shutdown() coroutine with ask_exit payload so quit/exit properly terminates the Jupyter console session - Add do_is_complete() to handle is_complete_request, eliminating the double-Enter required to submit input in jupyter-console - Enable code_display_data tests on all platforms (was Linux-only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeWarning: coroutine 'ProcessMetaKernel.do_shutdown' was never awaitedwhen user typesquit/exitin a cell — replaces the unawaited coroutine call with the standard Jupyterask_exitpayload so the console exits cleanlydo_is_complete()to eliminate the double-Enter required to submit input injupyter-console(was caused by unhandledis_complete_request)code_display_dataplot tests on all platforms — previously only ran on LinuxTest plan
just test-kernelpasses on macOS/Linux/Windowsexitinjupyter console --kernel=octaveexits cleanly in one Enterif true) show continuation prompt; single-line inputs execute immediately