Skip to content

Add --no-line-editing flag to Octave startup command#296

Merged
blink1073 merged 1 commit into
Calysto:mainfrom
blink1073:no-line-editing
Mar 16, 2026
Merged

Add --no-line-editing flag to Octave startup command#296
blink1073 merged 1 commit into
Calysto:mainfrom
blink1073:no-line-editing

Conversation

@blink1073
Copy link
Copy Markdown
Contributor

References

Description

Adds --no-line-editing to the Octave startup command in _create_repl. This flag disables readline-based line editing in the Octave subprocess, which improves performance by reducing overhead in the REPL interaction.

Changes

  • Added --no-line-editing to the Octave CLI flags in kernel.py:595

Backwards-incompatible changes

None

Testing

All 167 existing tests pass.

AI usage

  • Some or all of the content of this PR was generated by AI.
  • The human author has carefully reviewed this PR and run this code.
  • AI tools and models used: Claude Sonnet 4.6 (Claude Code)

@blink1073 blink1073 enabled auto-merge (squash) March 16, 2026 11:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.62%. Comparing base (9ccd573) to head (6f2adce).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #296   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files           6        6           
  Lines         430      430           
=======================================
  Hits          394      394           
  Misses         36       36           
Flag Coverage Δ
linux 91.39% <100.00%> (ø)
windows 91.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
octave_kernel/kernel.py 92.47% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blink1073 blink1073 merged commit 9705df5 into Calysto:main Mar 16, 2026
28 checks passed
@blink1073 blink1073 deleted the no-line-editing branch March 16, 2026 11:51
@blink1073 blink1073 mentioned this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant