Add Docker docs and test-docker justfile target#306
Merged
Conversation
- Add Docker installation section to README with token URL instructions - Add .dockerignore to exclude .git, .venv, and cache files from builds - Add test-docker justfile target that builds the image and verifies the octave kernelspec and octave executable are available - Update docker-build CI job to use just test-docker with Buildx caching - Remove .python-version (managed by Poetry)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 6 6
Lines 431 431
=======================================
Hits 395 395
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
N/A
Description
Adds documentation for the pre-built Docker image and a
test-dockerjustfile target that validates the image after building.Changes
README.mdwith instructions for pulling and running the image, including a note to click the token URL to open JupyterLab.dockerignoreto exclude.git,.venv, and cache files from Docker buildstest-dockerjustfile target that runsdocker-buildthen verifies theoctavekernelspec is listed and theoctaveexecutable is availabledocker-buildCI job to usejust test-dockerafter the Buildx build (with GHA layer caching preserved viaload: true).python-version(Python version is managed by Poetry)Backwards-incompatible changes
None
Testing
Ran
just test-dockerlocally — both checks pass (kernelspec listed,octave --versionsucceeds).AI usage
Tools: Claude (claude-sonnet-4-6)