Skip to content

Skip over bad injector class pattern#28

Merged
Cambis merged 1 commit into1.xfrom
bugfix/resolve-bad-injector-classname
Oct 23, 2025
Merged

Skip over bad injector class pattern#28
Cambis merged 1 commit into1.xfrom
bugfix/resolve-bad-injector-classname

Conversation

@Cambis
Copy link
Copy Markdown
Owner

@Cambis Cambis commented Oct 23, 2025

Description ✍️

If you have some bad configuration like:

SilverStripe\Core\Injector\Injector:
  MyClass:
    class: null

This would throw an error as we are expecting a string here, either way we should check that the value is a a string.

DoD checklist ✅

@Cambis Cambis merged commit e276575 into 1.x Oct 23, 2025
10 checks passed
@Cambis Cambis deleted the bugfix/resolve-bad-injector-classname branch October 23, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant