feat(governor): wire pressure broker to governor sink#1373
Merged
joelteply merged 1 commit intoMay 17, 2026
Conversation
This was referenced May 17, 2026
joelteply
added a commit
that referenced
this pull request
May 18, 2026
…ALOG §II) (#1387) PR-1 of inference-llm. Pure typed event surface for the local-LLM generation module. The module itself (composition → tokenizer → llama.cpp invoke → token stream) lands in PR-2/PR-3; PR-1 ships the wire so producers + consumers can build against it today. Unblocked by my just-shipped Lane H + recall + working-set stacks. What lands - InferenceRequestId — typed Uuid newtype; all four events carry the same field name (requestId on wire) for correlation - CompositionPlan — opaque ArtifactId reference; composer module fills the full shape later - SamplingParams { temperature, top_p, top_k, repeat_penalty } with llama.cpp-baseline defaults (0.8 / 0.95 / 40 / 1.1) - GenerationBudget { max_tokens, max_duration_ms } — both honored - FinishReason enum: Stop / MaxTokens / MaxDuration / StopSequence { matched } / Error { reason } — typed per Joel's never-swallow - InferenceRequest — [InferenceRequest] subscription event - InferenceComplete — emission with completion + finish + timing - FirstTokenEmitted — emission for TTFT observability (microsecond precision; sub-ms achievable on warm models) - ResidencyFault — emission when inference would need a not- resident page; sentinel learns + upgrades tier policy Tests 13 behavioral tests + 9 ts-rs export_bindings = 22 total. 22/22 pass. No regressions across other 2883 lib tests. Clippy baseline bump 154→156 — drift from recent canary merges. Fixed two doc-list warnings in this file (reworded "* 1000" math to avoid being parsed as a markdown list item). Stack - Lane H end-to-end (codex's #1331→#1373) - Working-set-manager + DAR end-to-end (mine, #1346→#1382) - THIS PR — inference-llm PR-1: typed event surface - NEXT — PR-2: InferenceLlmModule ServiceModule impl wired to the artifact dispatch - THEN — PR-3: tokenizer + llama.cpp invoke + token stream Co-authored-by: Test <test@test.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proof
Notes
No global governor singleton, no policy-file boot guess, no TS stopgap. This only wires the existing Rust broker alert sink into the module construction path.