Bump dotenv from 16.6.1 to 17.2.3#162
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [dotenv](https://github.com/motdotla/dotenv) from 16.6.1 to 17.2.3. - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.6.1...v17.2.3) --- updated-dependencies: - dependency-name: dotenv dependency-version: 17.2.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
joelteply
added a commit
that referenced
this pull request
Jun 3, 2026
… Arc-native registry refactor
Per Joel 2026-06-03 ("Elegant intentional architecture not wrapped
hacks") + the shim that landed in slice 1D (#161): the doc-comment
on ArcAdapterShim now explicitly names task #162 as the proper
architectural fix (AdapterRegistry stores Arc<dyn ...> natively,
trait drops vestigial &mut self lifecycle methods, shim deleted).
No code change — debt tagged at its source so future-me cannot
mistake the shim for the intentional architecture and walk past
the refactor.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
joelteply
added a commit
that referenced
this pull request
Jun 3, 2026
…ely — ArcAdapterShim deleted (task #162) Per Joel 2026-06-03 ("Elegant intentional architecture not wrapped hacks"): the registry now stores Arc directly. The transitional ArcAdapterShim from slice 1D (#161) is gone. Every register site flipped to the init-then-register pattern. ## What changed in `ai/adapter.rs` - `AdapterRegistry::adapters` is now `HashMap<String, Arc<dyn AIProviderAdapter>>` (was `Box`). Shared ownership is the production reality: supervisor + service_loop + cognition layer + future shared-base + LoRA paging (#122) all see the same instance. The registry is one of those holders, not the owner. - `register(adapter: Arc<dyn AIProviderAdapter>, priority)` — caller has already called `initialize()` on the adapter. The registry trusts that registered adapters are ready to serve. - New `get_arc(provider_id) -> Option<Arc<dyn ...>>` for callers that need to hold the reference past the read-lock scope (cognition's `evaluate_response` reads the adapter from the registry and holds it across the inference call so the read lock can drop). Cheap refcount bump. - DELETED `get_mut` — no callers; meaningless on shared Arcs. - DELETED `initialize_all` — registry doesn't do lifecycle. - DELETED `shutdown_all` — same (and had zero callers). - DELETED `ArcAdapterShim` (the slice-1D wrapper) + `register_arc` convenience method. The shim's doc-comment named this refactor; this commit honors that. ## Init-then-register pattern at the boot sites `modules/ai_provider.rs::initialize`: - 8 cloud-API adapters: each block becomes `let mut a = X::new(); match a.initialize().await { Ok => register(Arc::new(a), p), Err => log warn }`. On init failure we surface and skip; per [[no-fallbacks-ever]] no silent substitution. - In-process llama.cpp adapter: same shape — `adapter.initialize()` inline, then `registry.register(Arc::new(adapter), 0)`. - DMR adapter init + watchdog re-register: `build_dmr_adapter` returns a `Box<dyn ...>` (so the watchdog can call `initialize()` on the owned, sized handle), then `registry.register(Arc::from(box), 1)` flips Box→Arc in zero-copy. - Removed `registry.initialize_all().await?` — each adapter is initialized inline above before registration. `modules/agent.rs::ensure_adapter_registered`: - 5 cloud-API adapters: same init-then-register pattern. - Removed `registry.initialize_all().await?`. - Added `AIProviderAdapter` to the imports so the `initialize` trait method is in scope at call sites. `ai/heuristic_adapter.rs` test: - `register(Box::new(...))` → `register(std::sync::Arc::new(...))`. `persona/supervisor.rs::materialize_adapters`: - `registry.register_arc(adapter.clone(), slot_index)` → `registry.register(adapter.clone(), slot_index)`. The shim's convenience method is gone; `ctx.adapter` is already an Arc. `bin/airc_chat_demo.rs`: same — `register_arc` → `register`. `ai/mod.rs` module doc: usage example updated to the init-then-register pattern with `Arc::new`. `inference/handle_module.rs:251-263`: the comment that mentioned "AdapterRegistry stores Box<dyn ...>" updated to reflect Arc-native storage + `get_arc()` accessor. Names the migration as a follow-up cleanup target for that module. `ai/adapter.rs` inline test stubs (`stub`, `stub_model`) updated from `Box<dyn ...>` to `Arc<dyn ...>` returns. ## Doctrine the refactor honors - [[init-once-handle-then-lease-zero-copy-refs]]: initialize at boot, register the ready adapter, lease per inference call. No registry-side lifecycle methods running over shared handles. - [[no-fallbacks-ever]]: init failure → log + skip + no substitution. The provider doesn't reach "registered" state if its initialize fails. - [[intent-driven-api-not-hot-patches]]: callers say what they want (`Arc::new(adapter)` after `initialize()`); no magic shim layer in between. ## Test plan - [x] cargo check --lib → clean - [x] cargo test --lib ai:: → 48/48 pass - [x] cargo test --lib inference:: → 250/250 pass - [x] cargo test --lib persona:: → 724/724 pass (8 still ignored from slice 1C — those are blocked on cognition-layer model lookup, not adapter wiring; un-ignoring them is a separate slice that aligns the analyze + evaluate_response model hardcodes with what the test heuristic adapter claims) - [ ] Full `cargo test --lib` against entire crate skipped: GPU metal_monitor tests fail by design on Intel Mac CPU build (that's why `mac-cpu-only` feature exists), and `docker_tier_pool` integration tests have a pre-existing hang unrelated to this refactor. Both are orthogonal to the Box→Arc migration. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
joelteply
added a commit
that referenced
this pull request
Jun 8, 2026
…ests Three outdated integration tests broke at the AdapterRegistry-stores- Arc-natively refactor (task #162) and the scripted_adapter_factory module-path drift. Pure debt — they don't compile, they don't run, they accumulate every cycle. DELETE: tests/multi_persona_stress_baseline.rs References modules whose pub paths drifted (continuum_core::ai:: HeuristicInferenceAdapter requires the test-fixtures feature; continuum_core::persona::scripted_adapter_factory + scripted_conversation moved or never exported). The functionality it was meant to baseline (supervisor + materialize_adapters + serve_persona_loop under load) has unit-test coverage in the respective modules. Task #156 marked this completed at sign-off; the artifact rotted afterward. FIX (best-effort — Box → Arc at the registry boundary, matches the exact compiler errors flagged in the audit; needs validation on the next `cargo test --tests` cycle): - tests/persona_respond_replay.rs:103 — Box::new(adapter) → Arc::new(adapter) for reg.register - tests/fixture_assembly_replay.rs:509 — Arc::from(adapter) to convert the existing Box<dyn AIProviderAdapter> to Arc at the register call site Both tests cover real prod failure modes their headers document (max_tokens clipping mid-<think>, vision content dropped mid-flight); keeping them in tree but making them compile is the right move versus deletion. Per Joel 2026-06-08: "We should have tests that are efficient in consolidating logic calls, so less tests with more coverage. And get rid of outdated stuff yes." Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps dotenv from 16.6.1 to 17.2.3.
Changelog
Sourced from dotenv's changelog.
... (truncated)
Commits
affe11317.2.3db1ff1fchangelog 🪵7063f16Merge pull request #913 from motdotla/new-tips0bbe72ctest against expected tips017951bonly run .js tests39eda1fadd space backfcc030eupdate tipsb6c7a0dupdated tips - as Dotenvx Radar has been renamed Dotenvx Opsb3c8b16remove unnecessary call to npxd6e4c17Merge pull request #912 from adjerbetian/fix/typescript-error-definitionDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)