Gap analysis: 8 issues DONE, 2 PARTIAL from today's session#609
Merged
Conversation
DONE: CLI bundle, content routing, live STT, workspace paths, grid local node, persona stagger, dead seed code, credit detection. PARTIAL: tool expanders (2KB preview), session identity. TODO: Rust memory leak (#603).
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Phase 0 “Critical Bugs” gap analysis document to reflect the latest session’s status updates and links, keeping the planning doc aligned with recently-merged fixes.
Changes:
- Marks “Duplicate seed systems” as DONE and summarizes the cleanup work.
- Adds several new Phase 0 bug rows (STT, workspace bootstrap, tool expanders, grid local node, persona staggering, content routing, CLI bundle).
- Updates statuses/notes for recently addressed issues with PR/issue references.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | — | **Duplicate seed systems** | DEBT | Two seed paths: `seed-continuum.ts` (active, correct) and `api/data-seed/RoomDataSeed.ts` (dead code, wrong recipeIds). RoomDataSeed hardcodes `general-chat` for academy/pantheon. Dead code but confusing. Delete or consolidate. | | ||
| | — | **Duplicate seed systems** | DONE | Dead code deleted (PR #608): RoomDataSeed, DataSeeder, UserDataSeed, seedUsers, seed-data, clear-data — 1,362 lines removed. Kept: SeedConstants, ActivityDataSeed, SystemIdentity (still used by seed-continuum.ts). | | ||
| | — | **Seeding fragile on fresh installs** | BUG | Seeding is buggy, inefficient, and prone to complete failure on new installs. Needs single reliable path that works every time. | | ||
| | [#599](https://github.com/CambrianTech/continuum/issues/599) | **Live mode STT broken** | DONE | Three-layer fix: orphan watchdog timeout 60s→600s (#600), spawn_blocking for ORT deadlock (#601), ORT_DYLIB_PATH in start-workers.sh, install.sh auto-installs onnxruntime (#604). | |
There was a problem hiding this comment.
This row says ORT_DYLIB_PATH was fixed in start-workers.sh, but src/workers/start-workers.sh only sets ORT_DYLIB_PATH for /opt/homebrew/... and /usr/local/... and does not handle the ~/.continuum/lib/libonnxruntime.so path installed by src/scripts/install.sh. The ~/.continuum/lib export is currently in src/scripts/parallel-start.sh. Update the note to reference the correct script(s), or extend start-workers.sh to also export ORT_DYLIB_PATH from ~/.continuum/lib when present.
Suggested change
| | [#599](https://github.com/CambrianTech/continuum/issues/599) | **Live mode STT broken** | DONE | Three-layer fix: orphan watchdog timeout 60s→600s (#600), spawn_blocking for ORT deadlock (#601), ORT_DYLIB_PATH in start-workers.sh, install.sh auto-installs onnxruntime (#604). | | |
| | [#599](https://github.com/CambrianTech/continuum/issues/599) | **Live mode STT broken** | DONE | Three-layer fix: orphan watchdog timeout 60s→600s (#600), spawn_blocking for ORT deadlock (#601), ORT_DYLIB_PATH wired in worker start scripts (start-workers.sh, parallel-start.sh), install.sh auto-installs onnxruntime (#604). | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session summary of fixes landed today.