fix(install,#980-bug1): auto-install cmake on Mac (vendored llama.cpp prereq)#987
Merged
Conversation
… prereq) M1 Carl-validator pass (issue #980, Bug 1) hit a Carl-blocker: install.sh said "✅ Continuum Tower installed!" → npm start → Phase 2a Rust build dies in workers/llama → cmake-0.1.57/src/lib.rs:1132:5: failed to execute command → "is `cmake` not installed?" install.sh checked for git, docker, cargo, node — but NOT cmake — even though cmake is a hard requirement of the vendored llama.cpp build that runs as part of `npm start`. Carl saw the success banner, then the build crashed with no clear hint that cmake was the missing piece. Fix: add a cmake check next to cargo + node in the Mac (Darwin) prereq block. Auto-install via Homebrew when brew is available (matches the existing node pattern at line 303). Fall back to a clear error message naming both `brew install cmake` and `xcode-select --install` (the macOS CLI tools alternative that also includes cmake). Linux path is unchanged: continuum-core builds inside the Linux Docker image, so the Linux host doesn't need cmake at the host level — the container has its own toolchain. Test: dry-run on this M5 (cmake already installed → check passes immediately, no behaviour change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add cmake to the Mac (Darwin) prereq block in install.sh. Auto-install via Homebrew when brew is available; fall back to a clear error message naming both `brew install cmake` and `xcode-select --install` (the macOS CLI tools alternative).
Why
M1 Carl-validator pass (issue #980, Bug 1 — Carl-blocker) hit:
install.sh checked for git, docker, cargo, node — but NOT cmake — even though cmake is a hard requirement of the vendored llama.cpp build that runs as part of `npm start`. Carl saw the success banner, then the build crashed with no clear hint that cmake was the missing piece.
Pattern
Matches the existing node auto-install at line 303: check, info+install if brew available, fail with clear message if not.
Linux
Unchanged. continuum-core builds inside the Linux Docker image, so the Linux host doesn't need cmake at the host level — the container has its own toolchain.
Test
Dry-run on this M5 (cmake already installed → check passes immediately, no behaviour change).
Series context
This is the first concrete fix from #980's catalogued 10 bugs. Joel: "continue getting our carl case up to speed."
🤖 Generated with Claude Code