[pull] master from angular:master#887
Merged
pull[bot] merged 8 commits intoCammisuli:masterfrom Sep 21, 2021
Merged
Conversation
Improve the accessibility of button groups (such as those seen in `/about` and `/resources` to choose between the different categories) by making them easier to navigate via keyboard: - Make the individual buttons focusable via keyboard. (Previously, they were not focusable - despite being anchor elements, because they were lacking an `href` attribute.) - Give focused buttons a different style. PR Close #43460
Improve the accessibility of contributor cards (in `/about`) by making them easier to navigate via keyboard: - Show the (otherwise hidden) contributor info links on focus. - Make the "View bio" link focusable via keyboard (to give a clearer indication that users can click to view the bio - although technically the click is handled by an ancestor). - Make the flipped cards focusable via keyboard (so it is possible to click them to unflip). PR Close #43460
Previously, anchor links that were supposed to point to fragments inside the current page (e.g. `href="#something"`) would end up navigating to the homepage (`/`). This was due to them being resolved relative to the base URL, which is set to `/` (via `<base href="/">`). See also https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base#in-page_anchors. This commit fixes this issue by handling such links specially in `LocationService#handleAnchorClick()` and prepending the current path to the URL. This will also be useful for implementing a "skip to content" link as described in #42936. PR Close #43460
#43460) Add a link at the top of the page that allows skipping directly to the main content area. This allows people using assistive technologies to skip navigation-related parts of the page which are presented before the main content. Related resources: - [www.w3.org](https://www.w3.org/TR/WCAG20-TECHS/G1.html) - [accessibility.oit.ncsu.edu](https://accessibility.oit.ncsu.edu/it-accessibility-at-nc-state/developers/accessibility-handbook/mouse-and-keyboard-events/skip-to-main-content) - [css-tricks.com](https://css-tricks.com/how-to-create-a-skip-to-content-link) --- Example implementations on other websites: - **[accessibility.oit.ncsu.edu](https://accessibility.oit.ncsu.edu/)**:  - **[smile.amazon.com](https://smile.amazon.com/)**:  - **[chase.com](https://chase.com/)**:  - **[css-tricks.com](https://css-tricks.com/)**:  - **[github.com/angular/angular](https://github.com/angular/angular)**:  - **[news.sky.com](https://news.sky.com/)**:  - **[youtube.com](https://youtube.com/)**:  --- Angular.io implementation: - **[angular.io](https://angular.io/)**:  Fixes #42936 PR Close #43460
… files (#43519) The migration was previously touching files that did not have any expressions to migrate. This change ensures that the migration doesn't commit any updates on files that do not need them. This change, however, does not address the underlying issue with the migration and CRLF (which is fixed in a follow-up change). Related to #43416 PR Close #43519
…e characters (#43519) The previous replacement logic would not account for the CRLF line endings when applying replacements because it would replace the whole template with `template.content.length` which would not account for CRLF. This update applies individual expression edits at each location in the template rather than attempting to replace the whole template contents with a new string that contains the migrations. fixes #43416 PR Close #43519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )