Merged
Conversation
SpirinEgor
requested changes
Dec 18, 2023
Collaborator
SpirinEgor
left a comment
SpirinEgor
left a comment
There was a problem hiding this comment.
- Надо поправить замечания в пр к практике, это дополняющий пр, а не замещающий
- Есть тесты на функции перехода и на мейн в целом, но нет на каждый автомат. Точно надо проверять, что определенный ДКА принимает такие-то строки и не принимает другие
Comment on lines
33
to
+40
| first_fsm = create_fs_machine([0, 1, 2, 3], ["a", "b"], next_state1, 0, [3]) | ||
| second_fsm = create_fs_machine( | ||
| [0, 1, 2, 3, 4, 5, 6], | ||
| [*(str(n) for n in range(10)), ".", "E", "+", "-"], | ||
| next_state2, | ||
| 0, | ||
| [1, 3, 6], | ||
| ) |
Collaborator
There was a problem hiding this comment.
Такое в тестах будет неудобно переиспользовать, придется копипастить создание ДКА. Лучше вынести создание в отдельные функции
Comment on lines
42
to
+44
| if validate_string(first_fsm, user_string): | ||
| print("Your string belongs to first language: (a|b)*abb") | ||
| elif validate_string(second_fsm, user_string, -1): |
Collaborator
There was a problem hiding this comment.
А если будет еще 100 грамматик, так и будет каскад ифов?
Collaborator
|
Ну и зачем ты самостоятельно что-то мерджишь?( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.