Conversation
cyyeh
changed the title
paopa
reviewed
Jul 9, 2024
Contributor
paopa
left a comment
paopa
left a comment
There was a problem hiding this comment.
Thanks for your hard work! I have left two comments with my thoughts.
wren-ai-service/src/force_deploy.py
Outdated
Comment on lines
8
to
10
|
|
||
| load_dotenv(override=True) | ||
| if is_dev_env := os.getenv("ENV") and os.getenv("ENV").lower() == "dev": | ||
| if Path(".env.dev").exists(): | ||
| load_dotenv(".env.dev", override=True) |
Contributor
There was a problem hiding this comment.
what do you think using utils.load_env_vars func to instead of this.
Contributor
There was a problem hiding this comment.
I saw many place need checking and removing the slash at the end of an endpoint. I think we could extract them a func in utils module.
def endpoint_formatter(endpoint: str) -> str:
return endpoint.rstrip("/") if endpoint.endswith("/") else endpoint
Member
Author
There was a problem hiding this comment.
done, and the function name is remove_trailing_slash
onlyjackfrost
pushed a commit
that referenced
this pull request
Jul 11, 2024
* remove trailing / in urls of env vars * update * fix * fix bug * simplify codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.