feat(wren-ai-service): sql-answer-pipeline #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyeh
added
module/ai-service
cyyeh
force-pushed
the
feat/ai-service/sql-to-answer-v2
branch
7 times, most recently
from
9c4c077 to
8907a65
Compare
cyyeh
force-pushed
the
feat/ai-service/sql-to-answer-v2
branch
3 times, most recently
from
ffad664 to
57dec72
Compare
paopa
reviewed
Sep 11, 2024
| ) as response: | ||
| res = await response.json() | ||
| if res.get("data"): | ||
| return True, None |
Contributor
There was a problem hiding this comment.
how about keep the error and return one more value for data? I think using the same position to represent two meaning might be not a good choice.
e.g.
return status, data, error| pipelines: dict[str, BasicPipeline], | ||
| ): | ||
| self._pipelines = pipelines | ||
| self._sql_answer_results = {} |
Contributor
There was a problem hiding this comment.
I think it should be instead by the TTL cache. you could refer to the function in ask service.
cyyeh
force-pushed
the
feat/ai-service/sql-to-answer-v2
branch
from
57dec72 to
7e41852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.