chore(wren-ai-service): refine sql generation #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyeh
added
module/ai-service
paopa
reviewed
Oct 22, 2024
Comment on lines
261
to
267
| api_results += [ | ||
| AskResult(**result) for result in valid_sql_summary_results | ||
| ] | ||
| self._ask_results[query_id] = AskResultResponse( | ||
| status="generating", | ||
| response=api_results, | ||
| ) |
Contributor
There was a problem hiding this comment.
i think the results might be more than three. Do we need to remove any after the third candidate?
Comment on lines
291
to
293
| api_results += [ | ||
| AskResult(**result) for result in valid_sql_summary_results | ||
| ] |
Contributor
There was a problem hiding this comment.
the reference is already pointed to the attribute of response object, thus add new results into this variable, it might be occurring more than three candidates back. i think we need to check how many candidates had before putting them into the array.
Contributor
There was a problem hiding this comment.
Here is the example to show the case
from dataclasses import dataclass
@dataclass
class Demo:
id: str
@dataclass
class Resp:
demos: list[Demo]
results = []
results += [Demo(id="1")]
resp = Resp(demos=results)
print(resp)
results += [Demo(id="2")]
print(resp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.