Skip to content

Conversation

@oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Aug 24, 2022

Add a playground env for testing, please check the document.

@oscar60310 oscar60310 changed the title Feature: Initializing Vulcan lab [WIP] Feature: Initializing Vulcan lab Aug 24, 2022
@oscar60310 oscar60310 changed the title [WIP] Feature: Initializing Vulcan lab [WIP] Feature: Initialize Vulcan lab Aug 25, 2022
@oscar60310 oscar60310 force-pushed the chore/vulcan-lab branch 2 times, most recently from 5e131f8 to e01221b Compare August 25, 2022 03:38
@oscar60310 oscar60310 changed the title [WIP] Feature: Initialize Vulcan lab Feature: Initialize Vulcan lab Aug 25, 2022
@oscar60310 oscar60310 requested a review from kokokuo August 25, 2022 04:24
@oscar60310 oscar60310 marked this pull request as ready for review August 25, 2022 04:24
Base automatically changed from feature/doc-server to develop August 31, 2022 09:25
Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

# build and install for cli pakge
pkg-cli: ../../node_modules
@cd ../..; \
yarn nx install cli;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why we copy the vulcan dist core, build and serve to labs/playgrounds/node_modules/@vulcan-sql, but not include cli ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI package will be installed as a global package via npm, that is, it will be copied to .npm folder instead.

@kokokuo kokokuo merged commit 2e31094 into develop Sep 6, 2022
@oscar60310 oscar60310 deleted the chore/vulcan-lab branch September 6, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants