Skip to content

Conversation

@oscar60310
Copy link
Contributor

@oscar60310 oscar60310 commented Sep 26, 2022

Description

NX detects dependencies from our template js file, so we need to remove it manually.

const { VulcanServer } = require('@vulcan-sql/serve');

Issue ticket number

N/A

Additional Context

@vercel
Copy link

vercel bot commented Sep 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vulcan-sql-document ❌ Failed (Inspect) Sep 26, 2022 at 6:33AM (UTC)

@oscar60310 oscar60310 requested a review from kokokuo September 26, 2022 06:34
@codecov-commenter
Copy link

Codecov Report

Base: 92.60% // Head: 92.60% // No change to project coverage 👍

Coverage data is based on head (923605a) compared to base (4cbc840).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #91   +/-   ##
========================================
  Coverage    92.60%   92.60%           
========================================
  Files          259      259           
  Lines         3798     3798           
  Branches       481      481           
========================================
  Hits          3517     3517           
  Misses         185      185           
  Partials        96       96           
Flag Coverage Δ
build 94.90% <ø> (ø)
cli 89.38% <ø> (ø)
core 92.99% <ø> (ø)
extension-dbt 97.43% <ø> (ø)
extension-debug-tools 98.11% <ø> (ø)
extension-driver-duckdb 100.00% <ø> (ø)
extension-driver-pg 94.87% <ø> (ø)
integration-testing 96.15% <ø> (ø)
serve 90.38% <ø> (ø)
test-utility ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kokokuo kokokuo merged commit 9a7dd88 into develop Sep 26, 2022
@kokokuo kokokuo deleted the fix/fix-dependecies-issues branch September 26, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants