- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 393
 
Add Domain1D info to Python API #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83056dc    to
    6695071      
    Compare
  
    
          Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
- Coverage   75.24%   75.22%   -0.02%     
==========================================
  Files         454      454              
  Lines       56756    56776      +20     
  Branches     9373     9373              
==========================================
+ Hits        42704    42710       +6     
- Misses      10873    10887      +14     
  Partials     3179     3179              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is OK with me, with a couple of minor changes.
          
 Thanks, @speth! Change requests are addressed.  | 
    
Changes proposed in this pull request
Add a missing
updateThermocall prior to export asSolutionArray. This ensures consistent thermodynamic states.Flow1D::toArrayDomain1D.infoto Python API (same asSolutionArray.info)If applicable, fill in the issue number this pull request is fixing
Closes #2007
If applicable, provide an example illustrating new features this pull request is introducing
Other thoughts
Inconsistent states are only present prior to the first call to
Sim1D.solve; any subsequent output will be consistent as long as states are not overwritten. WhileSolutionArraywith inconsistent states may have been saved in prior versions of Cantera, a re-import toSim1D/Domain1Dwill still work correctly, as an inconsistent densityDis ignored. The same is not true if an inconsistentSolutionArrayis imported directly; in that case, states will be set usingSolution.TDYwith an incorrect pressure trace.Checklist
scons build&scons test) and unit tests address code coverage