-
-
Notifications
You must be signed in to change notification settings - Fork 393
sourcegen improvements #2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sourcegen improvements #2011
Conversation
ae9f113 to
3e8f122
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2011 +/- ##
=======================================
Coverage 75.23% 75.23%
=======================================
Files 454 454
Lines 56756 56756
Branches 9373 9373
=======================================
Hits 42703 42703
Misses 10874 10874
Partials 3179 3179 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0561835 to
c63f206
Compare
6a7f567 to
e04cf32
Compare
544f0c1 to
3435360
Compare
While '_auto' was useful for testing purposes, it is no longer needed. All relevant files start with 'ct', which is sufficient.
Docstrings containing '%Cantera' cause crashes in the MATLAB build process, as '%' is reserved for comments.
3435360 to
df97241
Compare
|
@speth ... I believe this is ready for a review. The only question I have is whether it's time to remove the disclaimers before releasing 3.2. My main reservations are related to Cantera/enhancements#228, but I don't know when/whether this would be implemented. Otherwise, this is pretty much converged. PS: one other thing that remains to be done is to issue compile time deprecation warnings for the legacy CLib. |
I think it's worth reserving the option of making breaking API changes to this interface for at least one release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. This all looks good to me.
Changes proposed in this pull request
\param[out]of typevector<>is not scaffolded correctly (was not used by CLib, but was also not covered by exception)intcrosswalk for methods that do not take a parameter\deprecatedmessage from C++ documentation and propagate annotation to generated CLib_autofrom the header configuration files. It is not needed.If applicable, fill in the issue number this pull request is fixing
Closes #2000
Closes Cantera/enhancements#232
Partially implements Cantera/enhancements#230
If applicable, provide an example illustrating new features this pull request is introducing
The issue pointed out in #1995 (comment) is resolved as:
Deprecation warnings are now propagated
Checklist
scons build&scons test) and unit tests address code coverage