[codex] replace background-action with repo-owned helper#1976
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a new Bash script to start/verify background services, replaces prior background-action usage in GitHub Actions with scripted service startup and PID/log outputs and cleanup, and makes Playwright optionally skip starting the frontend when SKIP_FRONTEND_START is set. Changes
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions
participant Script as start-background-service.sh
participant Service as Background Service
participant WaitOn as bunx wait-on
participant Log as Log File
GHA->>Script: invoke with BACKGROUND_* env vars
Script->>Script: validate vars & parse BACKGROUND_WAIT_ON
Script->>Log: ensure dir & truncate `BACKGROUND_LOG_PATH`
Script->>Service: start command with `nohup bash -lc ...` (stdout/stderr → Log)
Script->>Script: capture PID and optionally write `GITHUB_OUTPUT`
alt service stays running
Script->>Service: verify PID alive
Script->>WaitOn: run wait-on with targets, timeout, interval, --log --verbose
WaitOn->>WaitOn: poll targets
alt targets ready
WaitOn-->>Script: success
Script->>GHA: emit ready notice + PID
else timeout/failure
WaitOn-->>Script: failure
Script->>Log: tail configured log lines
Script->>GHA: emit error
end
else service exited early
Script->>Log: tail configured log lines
Script->>GHA: emit error
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/scripts/start-background-service.sh:
- Line 16: The script currently prints error markers like echo
"::error::BACKGROUND_SERVICE_NAME, BACKGROUND_RUN_COMMAND, BACKGROUND_WAIT_ON,
and BACKGROUND_LOG_PATH are required." to stdout; change these error echos (the
lines that print strings beginning with "::error::") to write to stderr instead
(for example, replace echo ":::error::..." with echo "::error::..." >&2 or use
printf "%s\n" "::error::..." >&2) and apply the same change for the other error
echo occurrences (the other "::error::..." messages in this file).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fb094107-3580-48a8-8bea-5f3fb11fe78d
📒 Files selected for processing (2)
.github/scripts/start-background-service.sh.github/workflows/tests.yml
|
1 participant
Summary (AI generated)
JarvusInnovations/background-actionusages in.github/workflows/tests.ymlwith a repo-owned background-service helpernohup, wait on pinnedbunx wait-on@8.0.1health checks, and emit grouped startup diagnostics when readiness failsMotivation (AI generated)
JarvusInnovations/background-actionis not actively maintained, and it hides too much of the failure context when a background service never becomes healthy or when later tests fail. Owning the startup logic in-repo removes the stale wrapper dependency and gives us clearer, version-pinned diagnostics around the exact services this workflow depends on.Business Impact (AI generated)
This lowers CI maintenance risk and shortens investigation time when local test infrastructure flakes in GitHub Actions. Faster root-cause visibility means less engineering time spent re-running jobs blindly and more confidence in the backend test signal that protects releases.
Test Plan (AI generated)
.github/scripts/start-background-service.shwithbash -nbunx wait-on, and captures the emitted outputs.github/workflows/tests.ymlformatting withbunx prettier --check --parser yamlRun testsworkflow passes on this branchGenerated with AI
Summary by CodeRabbit
New Features
Chores