Skip to content

fix(ci): allow reusable tests workflow PR read scope#1979

Merged
riderx merged 1 commit into
mainfrom
codex/fix-bump-version-workflow-permissions
Apr 29, 2026
Merged

fix(ci): allow reusable tests workflow PR read scope#1979
riderx merged 1 commit into
mainfrom
codex/fix-bump-version-workflow-permissions

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented Apr 29, 2026

Summary (AI generated)

  • add pull-requests: read to the bump_version.yml reusable test workflow call
  • align the caller permissions with .github/workflows/tests.yml so GitHub can validate the nested workflow

Motivation (AI generated)

The monorepo test workflow now declares pull-requests: read for its path filter job. bump_version.yml calls that workflow on pushes to main and development, but its job-level permissions did not allow that scope, so GitHub rejected the workflow file before CI could start.

Business Impact (AI generated)

This restores release automation on main and development. Without it, version bumping and follow-up release steps stop at workflow validation instead of running after merges.

Test Plan (AI generated)

  • Parse .github/workflows/bump_version.yml and .github/workflows/tests.yml locally after the change
  • Let the commit hook run successfully during commit creation
  • Verify GitHub Actions validates and runs the PR checks

Generated with AI

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow permissions to ensure proper access control and alignment with testing infrastructure requirements.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9342529-b6ba-488a-acab-eab164773966

📥 Commits

Reviewing files that changed from the base of the PR and between 13aa717 and 1f69ad4.

📒 Files selected for processing (1)
  • .github/workflows/bump_version.yml

📝 Walkthrough

Walkthrough

The pull request adds explicit pull-requests: read permissions to the test job in the workflow file to align with the reusable tests.yml workflow's path-filtering logic requirements.

Changes

Cohort / File(s) Summary
Workflow Permissions
.github/workflows/bump_version.yml
Added explicit pull-requests: read permission to the test job to satisfy requirements of the reusable tests.yml workflow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A rabbit hops with joy so bright,
Pull-requests now have read access right!
Permissions aligned, workflows in sync,
The tests shall pass in just a blink!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding pull-requests read scope to the bump_version workflow to enable the reusable tests workflow.
Description check ✅ Passed The description covers the summary, motivation, and test plan, but is missing the required sections for Screenshots and Checklist from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-bump-version-workflow-permissions

Review rate limit: 3/5 reviews remaining, refill in 23 minutes and 4 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented Apr 29, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/fix-bump-version-workflow-permissions (1f69ad4) with main (13aa717)

Open in CodSpeed

@sonarqubecloud
Copy link
Copy Markdown

@riderx riderx marked this pull request as ready for review April 29, 2026 10:57
@riderx riderx merged commit 51169aa into main Apr 29, 2026
50 checks passed
@riderx riderx deleted the codex/fix-bump-version-workflow-permissions branch April 29, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant