feat(build): improve native build setup flow#2045
Conversation
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThis PR implements optional platform selection for the native build request flow. When users omit the ChangesPlatform-Aware Build Flow
Sequence DiagramsequenceDiagram
actor User
participant CLI as Build CLI
participant Resolver as Platform Resolver
participant Prompt as Interactive Prompt
participant Build as Build Request
participant UI as Frontend UI
User->>CLI: Run build command<br/>(--platform omitted)
CLI->>Resolver: resolveBuildPlatform(undefined)
alt Interactive Terminal
Resolver->>Prompt: isInteractive() = true
Prompt->>User: Choose iOS or Android
User->>Prompt: Select platform
Prompt-->>Resolver: Platform selected
else Non-Interactive
Resolver-->>CLI: Error: platform required
end
Resolver-->>CLI: Resolved platform (ios|android)
CLI->>Build: Build request with<br/>resolved platform
Build->>Build: Validate credentials<br/>for platform
Build->>Build: Zip project for platform
Build->>Build: Upload & start build
Build-->>CLI: Build status/logs
CLI->>UI: Emit platform build counts
UI->>UI: Render platform-aware<br/>build steps
UI-->>User: Display build progress
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5785ec3b28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
1 participant
Summary (AI generated)
build requestprompt for iOS or Android when--platformis omitted in an interactive terminal.Motivation (AI generated)
Build onboarding should be usable directly from the console and less brittle in the CLI. Users can now choose the platform interactively in local shells, while CI/non-interactive usage still requires an explicit platform.
Business Impact (AI generated)
This reduces friction for users trying Capgo native builds, makes the console setup path clearer, and keeps build request behavior safer for automation.
Screenshot (AI generated)
Test Plan (AI generated)
bun lintbun typecheckbun run buildbun run lintincli/bun run buildincli/bun run test:build-platform-selectionincli/bun run test:mcpincli/bun run test:bundleincli//app/com.demo.app/buildsGenerated with AI
Summary by CodeRabbit
New Features
Documentation
Tests