Skip to content

[codex] Deploy Japan plugin worker on release#2063

Merged
riderx merged 1 commit into
mainfrom
codex/add-japan-plugin-deploy
May 7, 2026
Merged

[codex] Deploy Japan plugin worker on release#2063
riderx merged 1 commit into
mainfrom
codex/add-japan-plugin-deploy

Conversation

@riderx
Copy link
Copy Markdown
Member

@riderx riderx commented May 7, 2026

Summary (AI generated)

  • Added Japan (jp) to the plugin worker deployment matrix so release tags deploy plugin_jp with the other regional workers.
  • Added the matching deploy:cloudflare:plugin_jp:dev script alias for alpha deploy paths.
  • Pinned CLI version-detection fixtures to exact package versions so pnpm-based fixture installs stay deterministic in CI.

Motivation (AI generated)

Japan already had a Cloudflare worker environment and package deploy script, but the release workflow matrix did not include jp, so it was not auto-redeployed with the other plugin regions.

Business Impact (AI generated)

Keeping the Japan plugin worker on the same release cadence prevents the JP endpoint from serving stale /updates behavior after production fixes ship, including the deleted-bundle advisory path.

Test Plan (AI generated)

  • Parsed .github/workflows/build_and_deploy.yml as YAML.
  • Ran git diff --check.
  • Ran bun lint:backend.
  • Ran CLI version-detection fixture setup and tests.
  • Waited for GitHub CI to pass after pushing the PR.

Generated with AI

Summary by CodeRabbit

  • New Features

    • Added Japan region deployment support for the Cloudflare plugin.
  • Chores

    • Updated fixture projects with explicit version pinning for dependencies.
    • Added development deployment script for Japan region.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 08bf3239-ce8c-42bb-ba1d-60dbb3188710

📥 Commits

Reviewing files that changed from the base of the PR and between ca70694 and b2099b1.

📒 Files selected for processing (3)
  • .github/workflows/build_and_deploy.yml
  • cli/test/fixtures/setup-test-projects.sh
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The workflow .github/workflows/build_and_deploy.yml expands the deploy_plugin_regions deployment matrix to include Japan (jp) with label Japan (JP) and cf_target: plugin_jp. The root package.json adds a deploy:cloudflare:plugin_jp:dev script. The test fixture generator cli/test/fixtures/setup-test-projects.sh now emits fixed-version specifiers ($PACKAGE_VERSION) for @capgo/capacitor-updater and clarifies several trap success messages.

Changes

Deployment Region Expansion

Layer / File(s) Summary
Deployment Matrix & Script
.github/workflows/build_and_deploy.yml, package.json
deploy_plugin_regions matrix adds jp; matrix include adds region_label: Japan (JP) and cf_target: plugin_jp. Root package.json gains deploy:cloudflare:plugin_jp:dev script.

Fixture Dependency Specifier Updates

Layer / File(s) Summary
Fixture dependency specifiers
cli/test/fixtures/setup-test-projects.sh
Generator now writes @capgo/capacitor-updater as a fixed version ($PACKAGE_VERSION) instead of caret-prefixed (^$PACKAGE_VERSION) across standard and monorepo fixtures.
Trap fixture messages
cli/test/fixtures/setup-test-projects.sh
Success log messages updated to state that node_modules contains the fixture version rather than referencing "latest/real".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 In morning code I hop and trace,
Japan added to the deploy space,
Versions fixed in fixture lands,
Scripts now call with gentle hands,
A tiny patch — a tidy race.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding Japan plugin worker deployment to the release workflow.
Description check ✅ Passed The description includes summary, motivation, business impact, and test plan sections that align with template structure, though checklist items are not explicitly checked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/add-japan-plugin-deploy

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/build_and_deploy.yml:
- Around line 221-223: The workflow references a missing npm script
deploy:cloudflare:plugin_jp:dev in package.json causing dev deploys to fail; add
a new script named "deploy:cloudflare:plugin_jp:dev" to package.json that
mirrors the prod script's commands but uses dev-specific env/flags (or delegates
to the existing deploy:cloudflare:plugin_jp:prod logic with ENV=dev), ensuring
the script name exactly matches deploy:cloudflare:plugin_jp:dev so bun run
deploy:cloudflare:plugin_jp:dev invoked by the CI (from the workflow) succeeds.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 365dd062-1880-4193-a21c-bc85093602c0

📥 Commits

Reviewing files that changed from the base of the PR and between 910dad1 and ca70694.

📒 Files selected for processing (1)
  • .github/workflows/build_and_deploy.yml

Comment thread .github/workflows/build_and_deploy.yml
@codspeed-hq
Copy link
Copy Markdown
Contributor

codspeed-hq Bot commented May 7, 2026

Merging this PR will not alter performance

✅ 28 untouched benchmarks


Comparing codex/add-japan-plugin-deploy (b2099b1) with main (cc61384)

Open in CodSpeed

@riderx riderx force-pushed the codex/add-japan-plugin-deploy branch from ca70694 to c1e9ef6 Compare May 7, 2026 10:42
@riderx riderx force-pushed the codex/add-japan-plugin-deploy branch from c1e9ef6 to b2099b1 Compare May 7, 2026 10:56
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

@riderx riderx merged commit 73774d1 into main May 7, 2026
67 of 68 checks passed
@riderx riderx deleted the codex/add-japan-plugin-deploy branch May 7, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant